Bug 190128

Summary:

[WinCairo] Enable WPT tests environment.

Product:

WebKit

Reporter:

Basuke Suzuki <basuke>

Component:

Tools / Tests

Assignee:

Basuke Suzuki <basuke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, achristensen, basuke, commit-queue, ddkilzer, ews-watchlist, fujii.hironori, glenn, lforschler, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

190129

Attachments:

Description	Flags
PATCH	youennf: review+
PATCH	basuke: commit-queue-
PATCH	commit-queue: commit-queue-
PATCH	none
PATCH	none
PATCH	none

Basuke Suzuki

Reported 2018-10-01 05:25:57 PDT

Fix Windows path issues on run-webkit-tests script. Tests itself is kept skipped in this patch.

Attachments
PATCH (1.73 KB, patch) 2018-10-01 06:34 PDT, Basuke Suzuki	youennf: review+	Details Formatted Diff Diff
PATCH (1.75 KB, patch) 2018-10-02 00:39 PDT, Basuke Suzuki	basuke: commit-queue-	Details Formatted Diff Diff
PATCH (4.07 KB, patch) 2018-10-02 01:42 PDT, Basuke Suzuki	commit-queue: commit-queue-	Details Formatted Diff Diff
PATCH (4.00 KB, patch) 2018-10-02 01:48 PDT, Basuke Suzuki	no flags	Details Formatted Diff Diff
PATCH (4.00 KB, patch) 2018-10-02 01:50 PDT, Basuke Suzuki	no flags	Details Formatted Diff Diff
PATCH (2.00 KB, patch) 2018-10-02 01:52 PDT, Basuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Basuke Suzuki

Comment 1 2018-10-01 06:34:36 PDT

Created attachment 351241 [details] PATCH Escape backslashes in the cert path before putting into JSON config file.

youenn fablet

Comment 2 2018-10-01 13:52:26 PDT

Comment on attachment 351241 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=351241&action=review > Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:122 > + config_json = self._filesystem.read_text_file(config_wk_filename).replace("%CERTS_DIR%", self._filesystem.join(self._output_dir, "_wpt_certs").replace('\\', '\\\\')) Would it work to use json.dumps instead? Something like: s/self._filesystem.join(self._output_dir, "_wpt_certs").replace('\\', '\\\\')/json.dumps(self._filesystem.join(self._output_dir, "_wpt_certs"))/

Basuke Suzuki

Comment 3 2018-10-02 00:35:39 PDT

(In reply to youenn fablet from comment #2) > Comment on attachment 351241 [details] > PATCH > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351241&action=review > > > Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:122 > > + config_json = self._filesystem.read_text_file(config_wk_filename).replace("%CERTS_DIR%", self._filesystem.join(self._output_dir, "_wpt_certs").replace('\\', '\\\\')) > > Would it work to use json.dumps instead? > Something like: > s/self._filesystem.join(self._output_dir, "_wpt_certs").replace('\\', > '\\\\')/json.dumps(self._filesystem.join(self._output_dir, "_wpt_certs"))/ That must be more universal. Thanks.

Basuke Suzuki

Comment 4 2018-10-02 00:39:25 PDT

Created attachment 351352 [details] PATCH

Basuke Suzuki

Comment 5 2018-10-02 01:42:37 PDT

Created attachment 351355 [details] PATCH

WebKit Commit Bot

Comment 6 2018-10-02 01:44:35 PDT

Comment on attachment 351355 [details] PATCH Rejecting attachment 351355 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 351355, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=351355&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=190128&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 351355 from bug 190128. Fetching: https://bugs.webkit.org/attachment.cgi?id=351355 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit No diff found. at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 129. Parsed 0 diffs from patch file(s). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9423316

Basuke Suzuki

Comment 7 2018-10-02 01:48:43 PDT

Created attachment 351357 [details] PATCH

Basuke Suzuki

Comment 8 2018-10-02 01:50:47 PDT

Created attachment 351358 [details] PATCH

Basuke Suzuki

Comment 9 2018-10-02 01:52:10 PDT

Created attachment 351359 [details] PATCH

WebKit Commit Bot

Comment 10 2018-10-02 02:29:43 PDT

Comment on attachment 351359 [details] PATCH Clearing flags on attachment: 351359 Committed r236718: <https://trac.webkit.org/changeset/236718>