Bug 190093

Summary: RenderLayer::removeOnlyThisLayer() should not call updateLayerPositions()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, rniwa, ryanhaddad, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-sierra
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Archive of layout-test-results from ews117 for mac-sierra
none
Patch
zalan: review+
Patch none

Description Simon Fraser (smfr) 2018-09-28 14:51:11 PDT
RenderLayer::removeOnlyThisLayer() should not call updateLayerPositions()
Comment 1 Simon Fraser (smfr) 2018-09-28 14:54:40 PDT
Created attachment 351116 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-09-28 15:11:45 PDT
Bug 25252 is related.
Comment 3 EWS Watchlist 2018-09-28 16:46:05 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2018-09-28 16:46:07 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2018-09-28 16:56:55 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-09-28 16:56:57 PDT Comment hidden (obsolete)
Comment 7 EWS Watchlist 2018-09-28 17:04:44 PDT Comment hidden (obsolete)
Comment 8 EWS Watchlist 2018-09-28 17:04:46 PDT Comment hidden (obsolete)
Comment 9 Simon Fraser (smfr) 2018-09-28 17:12:52 PDT
Comment on attachment 351116 [details]
Patch

css3/blending/repaint/blend-mode-turn-off-isolation.html shows an actual failure.
Comment 10 Simon Fraser (smfr) 2018-09-28 17:22:56 PDT
Created attachment 351148 [details]
Patch
Comment 11 Simon Fraser (smfr) 2018-09-28 17:31:50 PDT
Created attachment 351149 [details]
Patch
Comment 12 WebKit Commit Bot 2018-09-28 18:53:43 PDT
Comment on attachment 351149 [details]
Patch

Clearing flags on attachment: 351149

Committed r236632: <https://trac.webkit.org/changeset/236632>
Comment 13 Radar WebKit Bug Importer 2018-09-29 11:56:28 PDT
<rdar://problem/44888632>
Comment 14 Ryan Haddad 2018-10-01 12:45:20 PDT
It looks like the three isolation tests rebaselined in this change are now failing on iOS Simulator (which has its own set of baselines):
https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r236674%20(159)/results.html
Comment 15 Simon Fraser (smfr) 2018-10-01 12:49:30 PDT
(In reply to Ryan Haddad from comment #14)
> It looks like the three isolation tests rebaselined in this change are now
> failing on iOS Simulator (which has its own set of baselines):
> https://build.webkit.org/results/
> Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r236674%20(159)/
> results.html

I'll fix.
Comment 16 Ryan Haddad 2018-10-01 14:25:36 PDT
(In reply to Simon Fraser (smfr) from comment #15)
> (In reply to Ryan Haddad from comment #14)
> > It looks like the three isolation tests rebaselined in this change are now
> > failing on iOS Simulator (which has its own set of baselines):
> > https://build.webkit.org/results/
> > Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r236674%20(159)/
> > results.html
> 
> I'll fix.
Rebaselined in https://trac.webkit.org/r236692