Bug 190075

Summary: cmake cannot run if python 2 isn't available
Product: WebKit Reporter: Mike Gorse <mgorse>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dean_johnson, lforschler, mcatanzaro, mgorse, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch.
mcatanzaro: review+, mcatanzaro: commit-queue-
Patch. none

Description Mike Gorse 2018-09-28 08:43:57 PDT
The build tools now support python 3, but cmake still fails if /usr/bin/python3 is available but /usr/bin/python is not.
See https://bugs.webkit.org/show_bug.cgi?id=156674#c36
Comment 1 Mike Gorse 2018-09-28 08:58:45 PDT
Created attachment 351078 [details]
Patch.
Comment 2 Michael Catanzaro 2018-09-28 10:49:46 PDT
Comment on attachment 351078 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=351078&action=review

> Source/cmake/WebKitCommon.cmake:24
>  
> +set(Python_ADDITIONAL_VERSIONS 3)
>      find_package(PythonInterp 2.7.0 REQUIRED)

The indentation is wrong here
Comment 3 Mike Gorse 2018-09-28 11:51:59 PDT
Created attachment 351098 [details]
Patch.

Fixed indentation.
Comment 4 WebKit Commit Bot 2018-09-28 18:00:47 PDT
Comment on attachment 351098 [details]
Patch.

Clearing flags on attachment: 351098

Committed r236629: <https://trac.webkit.org/changeset/236629>
Comment 5 WebKit Commit Bot 2018-09-28 18:00:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-28 18:01:45 PDT
<rdar://problem/44880316>