Bug 190074

Summary: Import WPT mimesniff resources
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191003
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-sierra
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Patch
none
Patch
none
Archive of layout-test-results from ews100 for mac-sierra
none
Patch
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch none

Description Rob Buis 2018-09-28 06:48:37 PDT
This is needed to activate many subtests in xhr/overridemimetype-blob.html.
Comment 1 Rob Buis 2018-09-28 06:55:45 PDT
Created attachment 351072 [details]
Patch
Comment 2 EWS Watchlist 2018-09-28 07:57:45 PDT
Comment on attachment 351072 [details]
Patch

Attachment 351072 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9381128

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
Comment 3 EWS Watchlist 2018-09-28 07:57:46 PDT
Created attachment 351074 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-09-28 08:08:54 PDT
Comment on attachment 351072 [details]
Patch

Attachment 351072 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9381158

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
Comment 5 EWS Watchlist 2018-09-28 08:08:56 PDT
Created attachment 351075 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 Rob Buis 2018-09-28 08:11:03 PDT
Created attachment 351076 [details]
Patch
Comment 7 Rob Buis 2018-09-28 10:08:32 PDT
Comment on attachment 351076 [details]
Patch

PTAL.
Comment 8 youenn fablet 2018-10-01 13:45:34 PDT
Comment on attachment 351076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351076&action=review

> LayoutTests/imported/w3c/resources/import-expectations.json:266
> +    "web-platform-tests/mimesniff/mime-types/resources": "import", 

Shouldn't it be "web-platform-tests/mimesniff": "import"?
Are we missing some mimisniff files?
Comment 9 youenn fablet 2018-10-01 13:46:28 PDT
(In reply to youenn fablet from comment #8)
> Comment on attachment 351076 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=351076&action=review
> 
> > LayoutTests/imported/w3c/resources/import-expectations.json:266
> > +    "web-platform-tests/mimesniff/mime-types/resources": "import", 
> 
> Shouldn't it be "web-platform-tests/mimesniff": "import"?
> Are we missing some mimisniff files?

Looking at the title of the bug, I think it is actually ok!
Would it be possible though to import mimesniff tests?
Comment 10 Rob Buis 2018-10-02 05:44:04 PDT
Created attachment 351376 [details]
Patch
Comment 11 EWS Watchlist 2018-10-02 06:32:29 PDT
Comment on attachment 351376 [details]
Patch

Attachment 351376 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9425784

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
Comment 12 EWS Watchlist 2018-10-02 06:32:31 PDT
Created attachment 351380 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 13 Rob Buis 2018-10-02 07:04:20 PDT
Created attachment 351384 [details]
Patch
Comment 14 EWS Watchlist 2018-10-02 08:34:09 PDT
Comment on attachment 351384 [details]
Patch

Attachment 351384 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9426782

New failing tests:
media/range-extract-contents-crash.html
Comment 15 EWS Watchlist 2018-10-02 08:34:11 PDT
Created attachment 351386 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 16 Rob Buis 2018-10-02 08:42:09 PDT
Created attachment 351388 [details]
Patch
Comment 17 Rob Buis 2018-10-02 23:41:54 PDT
Comment on attachment 351388 [details]
Patch

I was told to ignore the wincairo fail, so here we go...
Comment 18 WebKit Commit Bot 2018-10-03 00:08:57 PDT
Comment on attachment 351388 [details]
Patch

Clearing flags on attachment: 351388

Committed r236787: <https://trac.webkit.org/changeset/236787>
Comment 19 WebKit Commit Bot 2018-10-03 00:08:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 20 Radar WebKit Bug Importer 2018-10-03 00:09:24 PDT
<rdar://problem/44966613>