Bug 190074

Summary:

Import WPT mimesniff resources

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=191003

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Patch	none
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none

Rob Buis

Reported 2018-09-28 06:48:37 PDT

This is needed to activate many subtests in xhr/overridemimetype-blob.html.

Attachments
Patch (80.27 KB, patch) 2018-09-28 06:55 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.36 MB, application/zip) 2018-09-28 07:57 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.88 MB, application/zip) 2018-09-28 08:08 PDT, EWS Watchlist	no flags	Details
Patch (90.62 KB, patch) 2018-09-28 08:11 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (376.13 KB, patch) 2018-10-02 05:44 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.41 MB, application/zip) 2018-10-02 06:32 PDT, EWS Watchlist	no flags	Details
Patch (386.34 KB, patch) 2018-10-02 07:04 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.47 MB, application/zip) 2018-10-02 08:34 PDT, EWS Watchlist	no flags	Details
Patch (386.34 KB, patch) 2018-10-02 08:42 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2018-09-28 06:55:45 PDT

Created attachment 351072 [details] Patch

EWS Watchlist

Comment 2 2018-09-28 07:57:45 PDT

Comment on attachment 351072 [details] Patch Attachment 351072 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9381128 New failing tests: imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html

EWS Watchlist

Comment 3 2018-09-28 07:57:46 PDT

Created attachment 351074 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-09-28 08:08:54 PDT

Comment on attachment 351072 [details] Patch Attachment 351072 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9381158 New failing tests: imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html

EWS Watchlist

Comment 5 2018-09-28 08:08:56 PDT

Created attachment 351075 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Rob Buis

Comment 6 2018-09-28 08:11:03 PDT

Created attachment 351076 [details] Patch

Rob Buis

Comment 7 2018-09-28 10:08:32 PDT

Comment on attachment 351076 [details] Patch PTAL.

youenn fablet

Comment 8 2018-10-01 13:45:34 PDT

Comment on attachment 351076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351076&action=review > LayoutTests/imported/w3c/resources/import-expectations.json:266 > + "web-platform-tests/mimesniff/mime-types/resources": "import", Shouldn't it be "web-platform-tests/mimesniff": "import"? Are we missing some mimisniff files?

youenn fablet

Comment 9 2018-10-01 13:46:28 PDT

(In reply to youenn fablet from comment #8) > Comment on attachment 351076 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351076&action=review > > > LayoutTests/imported/w3c/resources/import-expectations.json:266 > > + "web-platform-tests/mimesniff/mime-types/resources": "import", > > Shouldn't it be "web-platform-tests/mimesniff": "import"? > Are we missing some mimisniff files? Looking at the title of the bug, I think it is actually ok! Would it be possible though to import mimesniff tests?

Rob Buis

Comment 10 2018-10-02 05:44:04 PDT

Created attachment 351376 [details] Patch

EWS Watchlist

Comment 11 2018-10-02 06:32:29 PDT

Comment on attachment 351376 [details] Patch Attachment 351376 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9425784 New failing tests: imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html

EWS Watchlist

Comment 12 2018-10-02 06:32:31 PDT

Created attachment 351380 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

Rob Buis

Comment 13 2018-10-02 07:04:20 PDT

Created attachment 351384 [details] Patch

EWS Watchlist

Comment 14 2018-10-02 08:34:09 PDT

Comment on attachment 351384 [details] Patch Attachment 351384 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9426782 New failing tests: media/range-extract-contents-crash.html

EWS Watchlist

Comment 15 2018-10-02 08:34:11 PDT

Created attachment 351386 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Rob Buis

Comment 16 2018-10-02 08:42:09 PDT

Created attachment 351388 [details] Patch

Rob Buis

Comment 17 2018-10-02 23:41:54 PDT

Comment on attachment 351388 [details] Patch I was told to ignore the wincairo fail, so here we go...

WebKit Commit Bot

Comment 18 2018-10-03 00:08:57 PDT

Comment on attachment 351388 [details] Patch Clearing flags on attachment: 351388 Committed r236787: <https://trac.webkit.org/changeset/236787>

WebKit Commit Bot

Comment 19 2018-10-03 00:08:59 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 20 2018-10-03 00:09:24 PDT

<rdar://problem/44966613>

Note You need to log in before you can comment on or make changes to this bug.