Bug 190063

Summary: JSC test stress/jsc-read.js doesn't support CRLF
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, jfbastien, keith_miller, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ross Kirsling
Reported 2018-09-27 17:17:44 PDT
JSC test stress/jsc-read.js doesn't support CRLF
Attachments
Patch (1.39 KB, patch)
2018-09-27 17:20 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (1.39 KB, patch)
2018-09-27 18:00 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-09-27 17:20:29 PDT
Created attachment 351028 [details] Patch
Ross Kirsling
Comment 2 2018-09-27 18:00:48 PDT
Created attachment 351032 [details] Patch
Yusuke Suzuki
Comment 3 2018-09-28 04:17:41 PDT
Comment on attachment 351032 [details] Patch r=me
WebKit Commit Bot
Comment 4 2018-09-28 08:31:54 PDT
Comment on attachment 351032 [details] Patch Clearing flags on attachment: 351032 Committed r236597: <https://trac.webkit.org/changeset/236597>
WebKit Commit Bot
Comment 5 2018-09-28 08:31:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-09-28 08:32:40 PDT
<rdar://problem/44864316>
Alexey Proskuryakov
Comment 7 2018-09-28 11:00:19 PDT
I've seen a couple CRLF bugs recently. Is it really the best solution to add special cases all over the place? While I'm not an expert on git or svn clients from Windows, I expect that configuring them to use proper line endings would be a better approach.
Note You need to log in before you can comment on or make changes to this bug.