Bug 190063

Summary: JSC test stress/jsc-read.js doesn't support CRLF
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, jfbastien, keith_miller, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ross Kirsling 2018-09-27 17:17:44 PDT
JSC test stress/jsc-read.js doesn't support CRLF
Comment 1 Ross Kirsling 2018-09-27 17:20:29 PDT
Created attachment 351028 [details]
Patch
Comment 2 Ross Kirsling 2018-09-27 18:00:48 PDT
Created attachment 351032 [details]
Patch
Comment 3 Yusuke Suzuki 2018-09-28 04:17:41 PDT
Comment on attachment 351032 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-09-28 08:31:54 PDT
Comment on attachment 351032 [details]
Patch

Clearing flags on attachment: 351032

Committed r236597: <https://trac.webkit.org/changeset/236597>
Comment 5 WebKit Commit Bot 2018-09-28 08:31:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-28 08:32:40 PDT
<rdar://problem/44864316>
Comment 7 Alexey Proskuryakov 2018-09-28 11:00:19 PDT
I've seen a couple CRLF bugs recently. Is it really the best solution to add special cases all over the place?

While I'm not an expert on git or svn clients from Windows, I expect that configuring them to use proper line endings would be a better approach.