Summary: | [iOS] WKWebView callout bar is missing Change Writing Direction item | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||
Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, commit-queue, thorton, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
mitz
2018-09-26 15:26:46 PDT
(In reply to mitz from comment #0) > and/or a left-to-right keyboard is active This should have said “right-to-left keyboard”. Created attachment 362138 [details]
Patch
Comment on attachment 362138 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362138&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2827 > + if (baseWritingDirection == WebCore::WritingDirection::LeftToRight && !UIKeyboardIsRightToLeftInputModeActive()) This confused me, you explained it ("active" should read "available" or something), it might need a comment. (In reply to Tim Horton from comment #4) > Comment on attachment 362138 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362138&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2827 > > + if (baseWritingDirection == WebCore::WritingDirection::LeftToRight && !UIKeyboardIsRightToLeftInputModeActive()) > > This confused me, you explained it ("active" should read "available" or > something), it might need a comment. 👍 Created attachment 362147 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 362147 [details]: media/modern-media-controls/compact-media-controls/compact-media-controls-layout.html bug 194720 (author: graouts@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 362147 [details] Patch for landing Clearing flags on attachment: 362147 Committed r241614: <https://trac.webkit.org/changeset/241614> |