Bug 190015 – [iOS] WKWebView callout bar is missing Change Writing Direction item

• Component: HTML Editing
• Status: RESOLVED FIXED

When the insertion point, or a selection, is in editable text, and the paragraph writing direction is left-to-right and/or a left-to-right keyboard is active, then the callout bar should contain one of the actions {makeTextWritingDirectionRightToLeft:, makeTextWritingDirectionLeftToRight:} (depending on which is the current direction). This works in UIWebView but apparently not implemented at all in WKWebView.

<rdar://problem/44810366>

(In reply to mitz from comment #0)
> and/or a left-to-right keyboard is active

This should have said “right-to-left keyboard”.

[Wenson Hsieh]

Created attachment 362138 [details]
Patch

[Tim Horton]

Comment on attachment 362138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362138&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2827
> +        if (baseWritingDirection == WebCore::WritingDirection::LeftToRight && !UIKeyboardIsRightToLeftInputModeActive())

This confused me, you explained it ("active" should read "available" or something), it might need a comment.

[Wenson Hsieh]

(In reply to Tim Horton from comment #4)
> Comment on attachment 362138 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362138&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2827
> > +        if (baseWritingDirection == WebCore::WritingDirection::LeftToRight && !UIKeyboardIsRightToLeftInputModeActive())
> 
> This confused me, you explained it ("active" should read "available" or
> something), it might need a comment.

👍

[Wenson Hsieh]

Created attachment 362147 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 362147 [details]:

media/modern-media-controls/compact-media-controls/compact-media-controls-layout.html bug 194720 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 362147 [details]
Patch for landing

Clearing flags on attachment: 362147

Committed r241614: <https://trac.webkit.org/changeset/241614>