Bug 190006

Summary: uidna_nameToASCII only needs a buffer capacity of 64
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Alex Christensen
Reported 2018-09-26 13:04:14 PDT
uidna_nameToASCII only needs a buffer capacity of 64
Attachments
Patch (4.36 KB, patch)
2018-09-26 13:06 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-09-26 13:06:24 PDT
Created attachment 350887 [details] Patch
Alex Christensen
Comment 2 2018-09-26 14:56:44 PDT
http://trac.webkit.org/r236527
Radar WebKit Bug Importer
Comment 3 2018-09-26 14:57:29 PDT
<rdar://problem/44809346>
Darin Adler
Comment 4 2018-09-30 20:17:28 PDT
Comment on attachment 350887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350887&action=review > Source/WebCore/platform/URLParser.cpp:2571 > + const size_t maxDomainLength = 64; Since this constant comes from the Unicode Technical Report and is not an arbitrary choice we made for WebKit, it would be good to mention that in a brief comment.
Note You need to log in before you can comment on or make changes to this bug.