Bug 189962

Summary: Web Inspector: Stricter block syntax in generated ObjC protocol interfaces
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2018-09-25 11:32:43 PDT
Stricter block syntax in generated ObjC protocol interfaces Convert: void(^)() To: void(^)(void) This is common in the success callbacks: > -- (void)enableWithErrorCallback:(void(^)(NSString *error))errorCallback successCallback:(void(^)())successCallback; > +- (void)enableWithErrorCallback:(void(^)(NSString *error))errorCallback successCallback:(void(^)(void))successCallback;
Attachments
[PATCH] Proposed Fix (9.83 KB, patch)
2018-09-25 11:33 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-09-25 11:32:53 PDT
<rdar://problem/44648287>
Joseph Pecoraro
Comment 2 2018-09-25 11:33:55 PDT
Created attachment 350770 [details] [PATCH] Proposed Fix
EWS Watchlist
Comment 3 2018-09-25 11:46:52 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Blaze Burg
Comment 4 2018-09-25 12:06:43 PDT
Comment on attachment 350770 [details] [PATCH] Proposed Fix rs=me
WebKit Commit Bot
Comment 5 2018-09-25 12:32:51 PDT
Comment on attachment 350770 [details] [PATCH] Proposed Fix Clearing flags on attachment: 350770 Committed r236469: <https://trac.webkit.org/changeset/236469>
WebKit Commit Bot
Comment 6 2018-09-25 12:32:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.