Bug 189959

Summary: Change from HAVE(CFNETWORK_STORAGE_PARTITIONING) to ENABLE(RESOURCE_LOAD_STATISTICS)
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cgarcia, cmarcelo, commit-queue, dbates, don.olmstead, esprehn+autocc, ews-watchlist, japhet, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

John Wilander
Reported 2018-09-25 11:24:45 PDT
We no longer make use of CF Network's cookie partitioning so we should change the compile-time flag to something that makes sense. This should also make it easier/cleaner for other ports.
Attachments
Patch (58.64 KB, patch)
2018-09-25 11:33 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-09-25 11:25:21 PDT
<rdar://problem/44767642>
John Wilander
Comment 2 2018-09-25 11:33:29 PDT
Created attachment 350769 [details] Patch
Chris Dumez
Comment 3 2018-09-25 15:07:52 PDT
Comment on attachment 350769 [details] Patch r=me
John Wilander
Comment 4 2018-09-25 15:08:26 PDT
Comment on attachment 350769 [details] Patch Thanks, Chris!
WebKit Commit Bot
Comment 5 2018-09-25 15:50:05 PDT
Comment on attachment 350769 [details] Patch Clearing flags on attachment: 350769 Committed r236485: <https://trac.webkit.org/changeset/236485>
WebKit Commit Bot
Comment 6 2018-09-25 15:50:07 PDT
All reviewed patches have been landed. Closing bug.
Don Olmstead
Comment 7 2018-12-10 14:58:35 PST
Hey John I'm wondering if there was a particular reason ENABLE_RESOURCE_LOAD_STATISTICS is set in Platform.h rather than FeatureDefines.xcconfig. I recently did https://trac.webkit.org/changeset/238809/webkit which synced the contents of FeatureDefines.xcconfig with the CMake side. Someone asked why ENABLE_RESOURCE_LOAD_STATISTICS wasn't present afterwards and when I went digging I found this commit. Should this be moved to FeatureDefines.xcconfig?
Note You need to log in before you can comment on or make changes to this bug.