Bug 18993

Summary:

Update of buttons in toolbar lags behind

Product:

WebKit

Reporter:

Aaron Digulla <digulla>

Component:

WebKit Website

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch for the two issues	darin: review+

Aaron Digulla

Reported 2008-05-11 01:34:57 PDT

Select a piece of text and make it bold. Now use the cursor keys to move in and out of the bold text. You'll see that the button in the toolbar lags behind by one keystroke. The source of the problem is that the cursor is in a new position when the key is released. To fix this, add an event listener for "keyup" in FancyToolbar.prototype.show() (just copy the line with "keypress"). Don't forget to remove the event listener in FancyToolbar.prototype.hidden(). Also, the call to loadFancyToolbars() in index.html is no longer necessary.

Attachments
Patch for the two issues (1.85 KB, patch) 2008-05-11 01:36 PDT, Aaron Digulla	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aaron Digulla

Comment 1 2008-05-11 01:36:09 PDT

Created attachment 21065 [details] Patch for the two issues

Robert Blaut

Comment 2 2008-06-13 12:33:02 PDT

Comment on attachment 21065 [details] Patch for the two issues I suppose you have asked for review ;)

Darin Adler

Comment 3 2008-06-13 14:02:01 PDT

Comment on attachment 21065 [details] Patch for the two issues r=me

Aaron Digulla

Comment 4 2008-06-22 13:32:26 PDT

Just apply the code to the project. It's just three lines that are changed!

Mark Rowe (bdash)

Comment 5 2008-06-22 18:27:19 PDT

Landed in r34736.

Aaron Digulla

Comment 6 2008-06-23 14:17:37 PDT

Verified in r34746. Should I mark this bug as verified or who does that?

Note You need to log in before you can comment on or make changes to this bug.