Bug 189925

Summary: [Payment Request] Events cleanup
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, cdumez, commit-queue, dino, eric.carlson, ews-watchlist, keith_miller, rniwa, sam, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andy Estes
Reported 2018-09-24 13:04:30 PDT
[Payment Request] Events cleanup
Attachments
Patch (38.41 KB, patch)
2018-09-24 13:21 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2018-09-24 13:21:04 PDT
Created attachment 350676 [details] Patch
EWS Watchlist
Comment 2 2018-09-24 13:23:51 PDT
Attachment 350676 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp:52: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2018-09-24 14:48:21 PDT
Comment on attachment 350676 [details] Patch Clearing flags on attachment: 350676 Committed r236429: <https://trac.webkit.org/changeset/236429>
WebKit Commit Bot
Comment 4 2018-09-24 14:48:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-09-24 14:49:29 PDT
<rdar://problem/44741059>
Note You need to log in before you can comment on or make changes to this bug.