Bug 18990
| Summary: | SquirrelFish: Function.toString loses new lines | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | ap, ggaren, gyuyoung, mjs, zwarich |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Oliver Hunt
Regardless of formatting Function.toString now appears to actively strip formatting, try
createPkg=function(_1){
var _2=_1.split("."),len=_2.length;
var _3=this.global;
for(var i=0;i<len-1&&_3&&_2[i];i++){
_3=(_3[_2[i]])?_3[_2[i]]:_3[_2[i]]={};
}
return {pkg:_3,className:(len>0)?_2[len-1]:""};
};
in the inspector, and cry at the out put.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Bug 24350 is a compatibility regression caused by this.
Cameron Zwarich (cpst)
I assigned bug 24350 to myself, but I may not fix it by fixing this bug, so I won't assign this one to myself.
Geoffrey Garen
I talked to Oliver on IRC.
He said this bug was about newlines being stripped from the function. He said it seems to have been an Inspector bug, which was resolved.
Bug 24350 and the issue of pretty printing are separate. Maybe we need another bug to cover the pretty printing feature.