Bug 189898

Summary:

Separate Mac and iOS implementation of windowsKeyCodeForCharCode()

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

iPhone / iPad

OS:

iOS 11

Bug Depends on:

Bug Blocks:

190571

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+

Daniel Bates

Reported 2018-09-23 15:01:38 PDT

Currently Mac and iOS share the same base implementation of windowsKeyCodeForCharCode() that is modified at compile-time depending on whether we are building for Mac and iOS.

Attachments
Patch (12.42 KB, patch) 2018-09-23 15:21 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (12.44 KB, patch) 2018-09-24 12:20 PDT, Daniel Bates	thorton: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2018-09-23 15:21:04 PDT

Created attachment 350591 [details] Patch

Daniel Bates

Comment 2 2018-09-24 12:20:25 PDT

Created attachment 350662 [details] Patch

Daniel Bates

Comment 3 2018-09-24 12:21:27 PDT

Comment on attachment 350662 [details] Patch Rebased patch following the landing of the patch for bug #189604.

Tim Horton

Comment 4 2018-09-24 12:29:51 PDT

Comment on attachment 350662 [details] Patch This is kind of weirdly the opposite direction I would usually go but it seems ok.

Daniel Bates

Comment 5 2018-09-24 12:31:37 PDT

The motivation of this patch is to clean up the Mac and iOS char code to Windows virtual key code. This is a step towards teaching the keyboard code how to map various special non-visible keys on iOS [1]. [1] <https://developer.apple.com/documentation/uikit/uikeycommand/input_strings_for_special_keys?changes=_2&language=objc>

Daniel Bates

Comment 6 2018-09-24 13:47:47 PDT

Committed r236427: <https://trac.webkit.org/changeset/236427>

Radar WebKit Bug Importer

Comment 7 2018-09-24 13:48:23 PDT

<rdar://problem/44738357>

Daniel Bates

Comment 8 2018-09-25 10:20:55 PDT

Comment on attachment 350662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350662&action=review > Source/WebCore/ChangeLog:12 > + Mac and iOS have significant differences in how they represent function keys. It is not worthwhile > + to share windowsKeyCodeForCharCode() between them given these differences. On Mac function keys The primary reason windowsKeyCodeForCharCode() was shared was to support testing using window.eventSender in iOS DRT of special keys (e.g. F1) as we also shared much of the window.eventSender machinery for Mac and iOS. We have not been running DRT for iOS on build.webkit.org or EWS for at least a year now :( The lack of iOS DRT bots to catch regressions is another reason why it is not worthwhile to continue sharing windowsKeyCodeForCharCode(). We may want to consider removing the iOS DRT code as it is currently bit rotting.

Note You need to log in before you can comment on or make changes to this bug.