Bug 189862

Summary: [WebVTT] Change name of WebVTT region attribute 'height' to 'lines'.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2018-09-21 15:15:53 PDT
The new spec. has changed the name of the 'height' attribute to 'lines', see https://w3c.github.io/webvtt/#region-settings.
Attachments
Patch (15.56 KB, patch)
2018-09-21 15:53 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2018-09-21 15:53:45 PDT
Created attachment 350448 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-09-21 15:54:22 PDT
<rdar://problem/44695428>
Per Arne Vollan
Comment 3 2018-09-24 09:12:22 PDT
Comment on attachment 350448 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 4 2018-09-24 09:39:11 PDT
Comment on attachment 350448 [details] Patch Clearing flags on attachment: 350448 Committed r236403: <https://trac.webkit.org/changeset/236403>
WebKit Commit Bot
Comment 5 2018-09-24 09:39:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.