| Summary: | Exception messages in console not always obvious | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Timothy Hatcher <timothy> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aroben, timothy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
What would make it more obvious? (In reply to comment #1) > What would make it more obvious? Maybe something as simple as prefixing the exception with "Exception: " would help. Yeah, i was thinking something along the lines of what adam referred to. This recently regressed a little, we no longer show a small red cross. And some cases the text isn't red. I have a fix that make these cases clear and consistent. Prefixing isn't a trivial change, so I will save that for another rainy day. Created attachment 28184 [details]
Proposed Patch
Created attachment 28185 [details]
Screenshot of new design
Comment on attachment 28184 [details] Proposed Patch > (WebInspector.Console.prototype._formaterror): Add an error-message > classed span around the message to show in red and remove the > console-message-url class from the link so it doesn't float right. > Instead inclose the link in parenthesis and use displayNameForURL Typos: inclose -> enclose, parenthesis -> parentheses > (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify > how line numbers are shown since link underlining a string with > parenthesis looks bad. Typo: parenthesis -> parentheses Can you make a manual test? r=me |
Doing the following example in the console: q=({valueOf:function(){console.log("argh"); throw "foo";}}) q++ Will result in a small red cross, with the text "foo". It is not obvious however that the "foo" text is in fact an exception.