Bug 189817

Summary:

Web Inspector: remove setting for Sources tab

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Devin Rousso

Reported 2018-09-20 20:18:57 PDT

The Sources tab is almost a direct copy of the Resources tab, so there's no reason to have both.

Attachments
Patch (37.18 KB, patch) 2018-09-20 20:49 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (37.93 KB, patch) 2018-09-21 11:39 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2018-09-20 20:49:10 PDT

Created attachment 350319 [details] Patch

Joseph Pecoraro

Comment 2 2018-09-21 11:08:31 PDT

Comment on attachment 350319 [details] Patch r=me

WebKit Commit Bot

Comment 3 2018-09-21 11:34:06 PDT

Comment on attachment 350319 [details] Patch Rejecting attachment 350319 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 350319, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=350319&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=189817&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 350319 from bug 189817. Fetching: https://bugs.webkit.org/attachment.cgi?id=350319 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 11 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js Hunk #1 succeeded at 337 (offset -7 lines). Hunk #2 succeeded at 711 (offset -12 lines). Hunk #3 succeeded at 801 (offset -12 lines). patching file Source/WebInspectorUI/UserInterface/Base/Main.js patching file Source/WebInspectorUI/UserInterface/Base/Setting.js Hunk #1 FAILED at 120. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Base/Setting.js.rej patching file Source/WebInspectorUI/UserInterface/Main.html Hunk #1 succeeded at 178 (offset -3 lines). Hunk #2 succeeded at 517 (offset -4 lines). Hunk #3 succeeded at 730 (offset -7 lines). patching file Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js patching file Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js Hunk #1 succeeded at 244 (offset -5 lines). Hunk #2 succeeded at 265 with fuzz 2 (offset -9 lines). patching file Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js patching file Source/WebInspectorUI/UserInterface/Views/SourcesSidebarPanel.css rm 'Source/WebInspectorUI/UserInterface/Views/SourcesSidebarPanel.css' patching file Source/WebInspectorUI/UserInterface/Views/SourcesSidebarPanel.js rm 'Source/WebInspectorUI/UserInterface/Views/SourcesSidebarPanel.js' patching file Source/WebInspectorUI/UserInterface/Views/SourcesTabContentView.js rm 'Source/WebInspectorUI/UserInterface/Views/SourcesTabContentView.js' Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9299070

Devin Rousso

Comment 4 2018-09-21 11:39:06 PDT

Created attachment 350392 [details] Patch

WebKit Commit Bot

Comment 5 2018-09-21 11:56:08 PDT

Comment on attachment 350392 [details] Patch Clearing flags on attachment: 350392 Committed r236342: <https://trac.webkit.org/changeset/236342>

WebKit Commit Bot

Comment 6 2018-09-21 11:56:10 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2018-09-21 11:57:19 PDT

<rdar://problem/44687957>

Note You need to log in before you can comment on or make changes to this bug.