Bug 189814

Summary: Web Inspector: remove LegacyTabBar
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED WONTFIX    
Severity: Normal CC: achristensen, inspector-bugzilla-changes, joepeck, mattbaker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2018-09-20 20:06:28 PDT
The legacy tab bar has been hidden behind an "experimental" setting for almost a year. It's time that we remove it.
Attachments
Patch (65.35 KB, patch)
2018-09-20 20:11 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (68.09 KB, patch)
2018-09-20 21:37 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-09-20 20:11:16 PDT
Created attachment 350310 [details] Patch
Devin Rousso
Comment 2 2018-09-20 21:37:20 PDT
Created attachment 350326 [details] Patch Forgot to upload my changes to what files are included
Joseph Pecoraro
Comment 3 2018-09-21 11:03:42 PDT
I'll let Matt review this one. The code changes look good, but I think he had more plans for the new tab bar?
Matt Baker
Comment 4 2018-09-21 11:06:35 PDT
I was meaning to comment on this. Offline we talked about removing legacy Styles Sidebar and the Sources setting, but the LegacyTabBar is still needed. Once we resume development on the redesigned TabBar, we'll want to keep things behind a feature flag until it is ready to ship.
Alex Christensen
Comment 5 2021-11-01 12:55:57 PDT
Comment on attachment 350326 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Note You need to log in before you can comment on or make changes to this bug.