Bug 189800 – [WPE] Be very permissive in the MiniBrowser.

• Component: New Bugs
• Status: RESOLVED FIXED

[Thibault Saunier]

[WPE] Be very permissive in the MiniBrowser.

[Thibault Saunier]

Created attachment 350256 [details]
Patch

[EWS Watchlist]

Attachment 350256 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Thibault Saunier]

Created attachment 350257 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 350257 [details]
Patch

Clearing flags on attachment: 350257

Committed r236385: <https://trac.webkit.org/changeset/236385>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44704628>

[Carlos Garcia Campos]

Comment on attachment 350257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350257&action=review

I don't understand this patch, by default the web view accepts all requests except the response ones when the content type is not supported. Why do we want to accept content that the web view doesn't know how to handle?

> Tools/MiniBrowser/wpe/main.cpp:189
> +    g_signal_connect(webView, "permission-request", G_CALLBACK(decidePermissionRequest), NULL);

NULL -> nullptr

[Thibault Saunier]

(In reply to Carlos Garcia Campos from comment #7)
> Comment on attachment 350257 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=350257&action=review
> 
> I don't understand this patch, by default the web view accepts all requests
> except the response ones when the content type is not supported. Why do we
> want to accept content that the web view doesn't know how to handle?

I must be missing something, but this is to give permissions to access external devices (mic/cam/etc...).

[Carlos Garcia Campos]

(In reply to Thibault Saunier from comment #8)
> (In reply to Carlos Garcia Campos from comment #7)
> > Comment on attachment 350257 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=350257&action=review
> > 
> > I don't understand this patch, by default the web view accepts all requests
> > except the response ones when the content type is not supported. Why do we
> > want to accept content that the web view doesn't know how to handle?
> 
> I must be missing something, but this is to give permissions to access
> external devices (mic/cam/etc...).

No, I was wrong, I thought this was for policy decisions. Permission requests are used for more than devices, they are also used for geolocation, notifications, etc. The default behavior is to deny everything because browsers are expected to ask the user for permission, but we don't have a way to do that in WPE (AFAIK), so I guess this is ok, since MB is just for testing after all. Sorry for the noise.