Bug 189780

Summary: [JSC] Optimize Array#lastIndexOf
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2018-09-20 01:25:05 PDT
[JSC] Optimize Array#lastIndexOf
Attachments
Patch (15.46 KB, patch)
2018-09-20 01:26 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-09-20 01:26:27 PDT
Created attachment 350179 [details] Patch
Saam Barati
Comment 2 2018-09-24 11:05:21 PDT
Comment on attachment 350179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350179&action=review > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1274 > + if (isJSArray(thisObject)) { There is a ton of duplicate code here with indexOf. Can we abstract away the way we iterate and combine these two implementations?
Yusuke Suzuki
Comment 3 2018-09-25 22:15:28 PDT
Comment on attachment 350179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350179&action=review >> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1274 >> + if (isJSArray(thisObject)) { > > There is a ton of duplicate code here with indexOf. Can we abstract away the way we iterate and combine these two implementations? Sounds good. Fixed.
Yusuke Suzuki
Comment 4 2018-09-25 22:16:27 PDT
Committed r236496: <https://trac.webkit.org/changeset/236496>
Radar WebKit Bug Importer
Comment 5 2018-09-25 22:17:19 PDT
<rdar://problem/44785524>
Yusuke Suzuki
Comment 6 2018-09-26 09:12:50 PDT
Committed r236505: <https://trac.webkit.org/changeset/236505>
Note You need to log in before you can comment on or make changes to this bug.