Bug 189681 – "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Chris Dumez]

"DidFirstNonVisuallyEmptyLayout" callback does not get called when restoring a page from PageCache.

[Chris Dumez]

<rdar://problem/44526171>

[Chris Dumez]

Created attachment 349943 [details]
Patch

[Chris Dumez]

Created attachment 349944 [details]
Patch

[alan]

Comment on attachment 349943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349943&action=review

> Source/WebCore/history/CachedFrame.cpp:159
> +    m_view->clear();

This might reset a bit more than what we actually need (and should).

[EWS Watchlist]

Comment on attachment 349944 [details]
Patch

Attachment 349944 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9248396

New failing tests:
compositing/iframes/page-cache-layer-tree.html

[EWS Watchlist]

Created attachment 349955 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349944 [details]
Patch

Attachment 349944 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9248802

New failing tests:
compositing/iframes/page-cache-layer-tree.html

[EWS Watchlist]

Created attachment 349969 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Chris Dumez]

(In reply to Build Bot from comment #7)
> Comment on attachment 349944 [details]
> Patch
> 
> Attachment 349944 [details] did not pass mac-debug-ews (mac):
> Output: https://webkit-queues.webkit.org/results/9248802
> 
> New failing tests:
> compositing/iframes/page-cache-layer-tree.html

--- /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/compositing/iframes/page-cache-layer-tree-expected.txt
+++ /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/compositing/iframes/page-cache-layer-tree-actual.txt
@@ -24,7 +24,7 @@
               (children 1
                 (GraphicsLayer
                   (anchor 0.00 0.00)
-                  (bounds 285.00 135.00)
+                  (bounds 285.00 150.00)
                   (children 1
                     (GraphicsLayer
                       (children 1
@@ -74,7 +74,7 @@
                   (children 1
                     (GraphicsLayer
                       (anchor 0.00 0.00)
-                      (bounds 285.00 135.00)
+                      (bounds 285.00 150.00)
                       (children 1
                         (GraphicsLayer
                           (children 1

[EWS Watchlist]

Comment on attachment 349944 [details]
Patch

Attachment 349944 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9249478

New failing tests:
compositing/iframes/page-cache-layer-tree.html
fast/scrolling/iframe-scrollable-after-back.html

[EWS Watchlist]

Created attachment 349973 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Chris Dumez]

(In reply to Chris Dumez from comment #9)
> (In reply to Build Bot from comment #7)
> > Comment on attachment 349944 [details]
> > Patch
> > 
> > Attachment 349944 [details] did not pass mac-debug-ews (mac):
> > Output: https://webkit-queues.webkit.org/results/9248802
> > 
> > New failing tests:
> > compositing/iframes/page-cache-layer-tree.html
> 
> ---
> /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/
> compositing/iframes/page-cache-layer-tree-expected.txt
> +++
> /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/
> compositing/iframes/page-cache-layer-tree-actual.txt
> @@ -24,7 +24,7 @@
>                (children 1
>                  (GraphicsLayer
>                    (anchor 0.00 0.00)
> -                  (bounds 285.00 135.00)
> +                  (bounds 285.00 150.00)
>                    (children 1
>                      (GraphicsLayer
>                        (children 1
> @@ -74,7 +74,7 @@
>                    (children 1
>                      (GraphicsLayer
>                        (anchor 0.00 0.00)
> -                      (bounds 285.00 135.00)
> +                      (bounds 285.00 150.00)
>                        (children 1
>                          (GraphicsLayer
>                            (children 1

The difference is that the scrollbars are gone, likely due to the setScrollbarsSuppressed(true) call in FrameView::clear().

I guess I will only reset the layout milestone related flags.

[Chris Dumez]

Created attachment 349974 [details]
Patch

[alan]

Comment on attachment 349974 [details]
Patch

Please replace the relevant variables in FrameView::reset() with the resetLayoutMilestones() call.

[Chris Dumez]

(In reply to zalan from comment #14)
> Comment on attachment 349974 [details]
> Patch
> 
> Please replace the relevant variables in FrameView::reset() with the
> resetLayoutMilestones() call.

Good idea, will do.

[Chris Dumez]

Created attachment 350022 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 350022 [details]
Patch

Clearing flags on attachment: 350022

Committed r236142: <https://trac.webkit.org/changeset/236142>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.