Summary: | "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||
Component: | Layout and Rendering | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, ews-watchlist, rniwa, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, zalan | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2018-09-17 14:47:05 PDT
Created attachment 349943 [details]
Patch
Created attachment 349944 [details]
Patch
Comment on attachment 349943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349943&action=review > Source/WebCore/history/CachedFrame.cpp:159 > + m_view->clear(); This might reset a bit more than what we actually need (and should). Comment on attachment 349944 [details] Patch Attachment 349944 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9248396 New failing tests: compositing/iframes/page-cache-layer-tree.html Created attachment 349955 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 349944 [details] Patch Attachment 349944 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9248802 New failing tests: compositing/iframes/page-cache-layer-tree.html Created attachment 349969 [details]
Archive of layout-test-results from ews112 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
(In reply to Build Bot from comment #7) > Comment on attachment 349944 [details] > Patch > > Attachment 349944 [details] did not pass mac-debug-ews (mac): > Output: https://webkit-queues.webkit.org/results/9248802 > > New failing tests: > compositing/iframes/page-cache-layer-tree.html --- /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/compositing/iframes/page-cache-layer-tree-expected.txt +++ /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/compositing/iframes/page-cache-layer-tree-actual.txt @@ -24,7 +24,7 @@ (children 1 (GraphicsLayer (anchor 0.00 0.00) - (bounds 285.00 135.00) + (bounds 285.00 150.00) (children 1 (GraphicsLayer (children 1 @@ -74,7 +74,7 @@ (children 1 (GraphicsLayer (anchor 0.00 0.00) - (bounds 285.00 135.00) + (bounds 285.00 150.00) (children 1 (GraphicsLayer (children 1 Comment on attachment 349944 [details] Patch Attachment 349944 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9249478 New failing tests: compositing/iframes/page-cache-layer-tree.html fast/scrolling/iframe-scrollable-after-back.html Created attachment 349973 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
(In reply to Chris Dumez from comment #9) > (In reply to Build Bot from comment #7) > > Comment on attachment 349944 [details] > > Patch > > > > Attachment 349944 [details] did not pass mac-debug-ews (mac): > > Output: https://webkit-queues.webkit.org/results/9248802 > > > > New failing tests: > > compositing/iframes/page-cache-layer-tree.html > > --- > /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/ > compositing/iframes/page-cache-layer-tree-expected.txt > +++ > /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/ > compositing/iframes/page-cache-layer-tree-actual.txt > @@ -24,7 +24,7 @@ > (children 1 > (GraphicsLayer > (anchor 0.00 0.00) > - (bounds 285.00 135.00) > + (bounds 285.00 150.00) > (children 1 > (GraphicsLayer > (children 1 > @@ -74,7 +74,7 @@ > (children 1 > (GraphicsLayer > (anchor 0.00 0.00) > - (bounds 285.00 135.00) > + (bounds 285.00 150.00) > (children 1 > (GraphicsLayer > (children 1 The difference is that the scrollbars are gone, likely due to the setScrollbarsSuppressed(true) call in FrameView::clear(). I guess I will only reset the layout milestone related flags. Created attachment 349974 [details]
Patch
Comment on attachment 349974 [details]
Patch
Please replace the relevant variables in FrameView::reset() with the resetLayoutMilestones() call.
(In reply to zalan from comment #14) > Comment on attachment 349974 [details] > Patch > > Please replace the relevant variables in FrameView::reset() with the > resetLayoutMilestones() call. Good idea, will do. Created attachment 350022 [details]
Patch
Comment on attachment 350022 [details] Patch Clearing flags on attachment: 350022 Committed r236142: <https://trac.webkit.org/changeset/236142> All reviewed patches have been landed. Closing bug. |