[Win] TestRunner::queueLoad() fails to generate correct url for some urls.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Basuke Suzuki]

In win/TestRunnerWin.cpp:327, it just generates a new url assuming passed url is relative url.

[Basuke Suzuki]

Created attachment 350136 [details]
PATCH

Use UrlCombineW Win32 API to generate correct URL for relative URLs.

[Basuke Suzuki]

Created attachment 350144 [details]
PATCH

[Fujii Hironori]

Comment on attachment 350144 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=350144&action=review

> Tools/DumpRenderTree/win/TestRunnerWin.cpp:346
> +    while (true) {

You can use UrlCombine instead of UrlCombineA.
You don't need this `while` loop because you can get minimum length of result.

DWORD bufferSize = 0;
auto result = UrlCombine(responseURL.data(), wURL.data(), nullptr, &bufferSize, 0);
if (result == E_POINTER) {
  buffer.resize(bufferSize);
  auto result = UrlCombine(responseURL.data(), wURL.data(), buffer.data(), &bufferSize, 0);
}

[Basuke Suzuki]

Oh, that's nice. Thanks.

[Basuke Suzuki]

Created attachment 350232 [details]
PATCH

[WebKit Commit Bot]

Comment on attachment 350232 [details]
PATCH

Clearing flags on attachment: 350232

Committed r236285: <https://trac.webkit.org/changeset/236285>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44656380>