Bug 189676

Summary: We must convert ProfileType to CheckStructureOrEmpty instead of CheckStructure
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2018-09-17 13:19:42 PDT
Because the incoming value may be TDZ. Since the TypeProfiler doesn't currently record TDZ values in any of its data structures, this is not a semantic change in how it will show you data. It just fixes crashes.
Attachments
patch (3.66 KB, patch)
2018-09-17 13:25 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-09-17 13:20:13 PDT
<rdar://problem/39682897>
Saam Barati
Comment 2 2018-09-17 13:25:57 PDT
Created attachment 349931 [details] patch
Michael Saboff
Comment 3 2018-09-17 13:27:41 PDT
Comment on attachment 349931 [details] patch r=me
WebKit Commit Bot
Comment 4 2018-09-17 15:21:42 PDT
Comment on attachment 349931 [details] patch Clearing flags on attachment: 349931 Committed r236089: <https://trac.webkit.org/changeset/236089>
WebKit Commit Bot
Comment 5 2018-09-17 15:21:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.