Bug 189665

Summary:

Add setting RequiresUserGestureToLoadVideo to enable more tests on iOS.

Product:

WebKit

Reporter:

Jeremy Jones <jeremyj-wk>

Component:

Media

Assignee:

Jeremy Jones <jeremyj-wk>

Status:

NEW

Severity:

Normal

CC:

achristensen, ews-watchlist, jeremyj-wk, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews105 for mac-sierra-wk2	none
Archive of layout-test-results from ews115 for mac-sierra	none
Archive of layout-test-results from ews117 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews105 for mac-sierra-wk2	none
Archive of layout-test-results from ews117 for mac-sierra	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews104 for mac-sierra-wk2	none

Jeremy Jones

Reported 2018-09-17 09:07:59 PDT

Add setting RequiresUserGestureToLoadVideo to enable more tests on iOS.

Attachments
Patch (19.76 KB, patch) 2018-09-17 09:09 PDT, Jeremy Jones	no flags	Details Formatted Diff Diff
Patch (23.66 KB, patch) 2018-09-17 09:16 PDT, Jeremy Jones	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.28 MB, application/zip) 2018-09-17 11:03 PDT, EWS Watchlist	no flags	Details
Patch (23.23 KB, patch) 2018-09-29 16:39 PDT, Jeremy Jones	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.43 MB, application/zip) 2018-09-29 17:47 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.92 MB, application/zip) 2018-09-29 17:57 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (3.09 MB, application/zip) 2018-09-29 18:47 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (3.08 MB, application/zip) 2018-09-29 20:41 PDT, EWS Watchlist	no flags	Details
Patch (26.10 KB, patch) 2018-09-30 18:45 PDT, Jeremy Jones	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.34 MB, application/zip) 2018-09-30 19:52 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.90 MB, text/plain) 2018-09-30 20:01 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (3.06 MB, application/zip) 2018-09-30 20:43 PDT, EWS Watchlist	no flags	Details
Patch (26.73 KB, patch) 2018-10-01 10:26 PDT, Jeremy Jones	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.89 MB, application/zip) 2018-10-01 12:06 PDT, EWS Watchlist	no flags	Details
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Jeremy Jones

Comment 1 2018-09-17 09:09:15 PDT

Created attachment 349890 [details] Patch

Jeremy Jones

Comment 2 2018-09-17 09:12:35 PDT

rdar://problem/44522223

Jeremy Jones

Comment 3 2018-09-17 09:16:23 PDT

Created attachment 349891 [details] Patch

EWS Watchlist

Comment 4 2018-09-17 11:03:25 PDT

Comment on attachment 349891 [details] Patch Attachment 349891 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9244145 New failing tests: media/modern-media-controls/start-support/start-support-lowPowerMode.html media/video-autoplay-allowed-but-fullscreen-required.html media/video-source-before-src.html

EWS Watchlist

Comment 5 2018-09-17 11:03:26 PDT

Created attachment 349906 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Jeremy Jones

Comment 6 2018-09-29 16:39:54 PDT

Created attachment 351201 [details] Patch

EWS Watchlist

Comment 7 2018-09-29 17:47:04 PDT

Comment on attachment 351201 [details] Patch Attachment 351201 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9397604 New failing tests: media/video-source-before-src.html

EWS Watchlist

Comment 8 2018-09-29 17:47:06 PDT

Created attachment 351203 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-09-29 17:57:50 PDT

Comment on attachment 351201 [details] Patch Attachment 351201 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9397616 New failing tests: media/video-source-before-src.html

EWS Watchlist

Comment 10 2018-09-29 17:57:52 PDT

Created attachment 351204 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 11 2018-09-29 18:47:21 PDT

Comment on attachment 351201 [details] Patch Attachment 351201 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9397677 New failing tests: media/video-source-before-src.html

EWS Watchlist

Comment 12 2018-09-29 18:47:23 PDT

Created attachment 351205 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 13 2018-09-29 20:41:52 PDT

Comment on attachment 351201 [details] Patch Attachment 351201 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9398295 New failing tests: media/video-source-before-src.html

EWS Watchlist

Comment 14 2018-09-29 20:41:54 PDT

Created attachment 351209 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

Jeremy Jones

Comment 15 2018-09-30 18:45:42 PDT

Created attachment 351221 [details] Patch

EWS Watchlist

Comment 16 2018-09-30 19:52:35 PDT

Comment on attachment 351221 [details] Patch Attachment 351221 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9406000 New failing tests: media/video-source-before-src.html

EWS Watchlist

Comment 17 2018-09-30 19:52:37 PDT

Created attachment 351222 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 18 2018-09-30 20:01:57 PDT

Comment on attachment 351221 [details] Patch Attachment 351221 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9406011 New failing tests: media/video-source-before-src.html

EWS Watchlist

Comment 19 2018-09-30 20:01:58 PDT

Created attachment 351223 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 20 2018-09-30 20:43:33 PDT

Comment on attachment 351221 [details] Patch Attachment 351221 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9406076 New failing tests: media/video-source-before-src.html

EWS Watchlist

Comment 21 2018-09-30 20:43:35 PDT

Created attachment 351224 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

Jeremy Jones

Comment 22 2018-10-01 10:26:47 PDT

Created attachment 351258 [details] Patch

EWS Watchlist

Comment 23 2018-10-01 12:06:57 PDT

Comment on attachment 351258 [details] Patch Attachment 351258 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9413258 New failing tests: media/range-extract-contents-crash.html

EWS Watchlist

Comment 24 2018-10-01 12:06:59 PDT

Created attachment 351283 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Alex Christensen

Comment 25 2021-11-01 12:55:18 PDT

Comment on attachment 351258 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.

Note You need to log in before you can comment on or make changes to this bug.