Bug 189635

Summary: Enable VCP for iOS and reenable it for MacOS
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews103 for mac-sierra
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Archive of layout-test-results from ews115 for mac-sierra
none
Patch
none
Patch for landing
none
iOS simulator build fix
none
iOS internal build fix none

youenn fablet
Reported 2018-09-14 14:58:53 PDT
Enable VCP for iOS and reenable it for MacOS
Attachments
Patch (22.56 KB, patch)
2018-09-14 16:05 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (22.87 KB, patch)
2018-09-14 16:24 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (22.95 KB, patch)
2018-09-14 16:59 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (24.78 KB, patch)
2018-09-14 17:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-sierra (2.30 MB, application/zip)
2018-09-14 18:33 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.11 MB, application/zip)
2018-09-14 19:11 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews115 for mac-sierra (3.05 MB, application/zip)
2018-09-14 19:34 PDT, EWS Watchlist 		no flags
Details
Patch (25.15 KB, patch)
2018-09-15 20:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.17 KB, patch)
2018-09-17 09:38 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
iOS simulator build fix (1.67 KB, patch)
2018-09-17 11:05 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
iOS internal build fix (2.59 KB, patch)
2018-09-17 15:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-09-14 14:59:44 PDT
<rdar://problem/43621029>
youenn fablet
Comment 2 2018-09-14 16:05:30 PDT
Created attachment 349822 [details] Patch
youenn fablet
Comment 3 2018-09-14 16:24:17 PDT
Created attachment 349827 [details] Patch
youenn fablet
Comment 4 2018-09-14 16:59:14 PDT
Created attachment 349831 [details] Patch
youenn fablet
Comment 5 2018-09-14 17:46:29 PDT
Created attachment 349840 [details] Patch
EWS Watchlist
Comment 6 2018-09-14 18:33:43 PDT
Comment on attachment 349840 [details] Patch Attachment 349840 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9222955 New failing tests: platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html
EWS Watchlist
Comment 7 2018-09-14 18:33:45 PDT
Created attachment 349843 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 8 2018-09-14 19:11:46 PDT
Comment on attachment 349840 [details] Patch Attachment 349840 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9223234 New failing tests: platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html
EWS Watchlist
Comment 9 2018-09-14 19:11:48 PDT
Created attachment 349846 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 10 2018-09-14 19:34:42 PDT
Comment on attachment 349840 [details] Patch Attachment 349840 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9223295 New failing tests: platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html
EWS Watchlist
Comment 11 2018-09-14 19:34:44 PDT
Created attachment 349847 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
youenn fablet
Comment 12 2018-09-15 20:43:56 PDT
Created attachment 349865 [details] Patch
Eric Carlson
Comment 13 2018-09-17 06:02:53 PDT
Comment on attachment 349865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349865&action=review > Source/WebCore/ChangeLog:11 > + Add internal API to knwo whether VCP is enabled so as to make capture-webrtc test pass on all platforms. Nit: “know” > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:36 > +#if (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) Nit: not new, but there are two spaces before the “&&”
youenn fablet
Comment 14 2018-09-17 09:38:05 PDT
Created attachment 349893 [details] Patch for landing
WebKit Commit Bot
Comment 15 2018-09-17 10:16:03 PDT
Comment on attachment 349893 [details] Patch for landing Clearing flags on attachment: 349893 Committed r236070: <https://trac.webkit.org/changeset/236070>
WebKit Commit Bot
Comment 16 2018-09-17 10:16:05 PDT
All reviewed patches have been landed. Closing bug.
youenn fablet
Comment 17 2018-09-17 11:05:22 PDT
Reopening to attach new patch.
youenn fablet
Comment 18 2018-09-17 11:05:23 PDT
Created attachment 349907 [details] iOS simulator build fix
WebKit Commit Bot
Comment 19 2018-09-17 11:49:59 PDT
Comment on attachment 349907 [details] iOS simulator build fix Clearing flags on attachment: 349907 Committed r236076: <https://trac.webkit.org/changeset/236076>
WebKit Commit Bot
Comment 20 2018-09-17 11:50:01 PDT
All reviewed patches have been landed. Closing bug.
youenn fablet
Comment 21 2018-09-17 15:43:44 PDT
Reopening to attach new patch.
youenn fablet
Comment 22 2018-09-17 15:43:45 PDT
Created attachment 349956 [details] iOS internal build fix
WebKit Commit Bot
Comment 23 2018-09-17 16:21:57 PDT
Comment on attachment 349956 [details] iOS internal build fix Clearing flags on attachment: 349956 Committed r236093: <https://trac.webkit.org/changeset/236093>
WebKit Commit Bot
Comment 24 2018-09-17 16:21:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.