Bug 189584 – [GStreamer] WebAudio idle/silence playback improvements

• Component: Platform
• Status: RESOLVED INVALID

[Philippe Normand]

Based on https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/d9f7dc6f0edcbee70cdc7e640b83bff61ad30ccd

[Philippe Normand]

Created attachment 349662 [details]
Patch

[EWS Watchlist]

Comment on attachment 349662 [details]
Patch

Attachment 349662 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9203122

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html

[EWS Watchlist]

Created attachment 349674 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Xabier Rodríguez Calvar]

Comment on attachment 349662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349662&action=review

It would be interesting to be a bit more verbose in the ChangLog

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:385
> +

Remove extra line...

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:396
> +            g_usleep(1000);

I think we can use WTF::sleep, can't we?

[Philippe Normand]

Comment on attachment 349662 [details]
Patch

Well, actually :)
After checking this patch more carefully, I wonder if we can perhaps have something different than a workaround.

I would like to experiment with a rewrite of this src element, make it inherit from audiosrc. An audio converter would internally handle the conversion to interleaved layout.

I started a patch...

[Philippe Normand]

(In reply to Philippe Normand from comment #5)
> Comment on attachment 349662 [details]
> Patch
> 
> Well, actually :)
> After checking this patch more carefully, I wonder if we can perhaps have
> something different than a workaround.
> 
> I would like to experiment with a rewrite of this src element, make it
> inherit from audiosrc. An audio converter would internally handle the
> conversion to interleaved layout.
> 
> I started a patch...

Rewriting this wouldn't be trivial due to the threading requirements of AudioWorklet...

This patch no longer applies and it seems downstream is not using it anymore. Closing.