Bug 189537

Summary: Remove unused httpPipeliningEnabled
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cdumez, ews-watchlist, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
cdumez: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews104 for mac-sierra-wk2 none

Alex Christensen
Reported 2018-09-11 20:43:42 PDT
Remove unused httpPipeliningEnabled
Attachments
Patch (12.02 KB, patch)
2018-09-11 20:44 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (13.25 KB, patch)
2018-09-12 09:13 PDT, Alex Christensen 		cdumez: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.98 MB, application/zip)
2018-09-13 02:40 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-09-11 20:44:10 PDT
Created attachment 349514 [details] Patch
Alex Christensen
Comment 2 2018-09-12 09:13:12 PDT
Created attachment 349554 [details] Patch
Chris Dumez
Comment 3 2018-09-12 13:36:39 PDT
Comment on attachment 349554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349554&action=review > Source/WebCore/ChangeLog:3 > + Remove unused httpPipeliningEnabled What do you mean by unused? It seems there is API Windows API to turn it on? Also a default.
Alex Christensen
Comment 4 2018-09-12 13:43:00 PDT
(In reply to Chris Dumez from comment #3) > Comment on attachment 349554 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=349554&action=review > > > Source/WebCore/ChangeLog:3 > > + Remove unused httpPipeliningEnabled > > What do you mean by unused? It seems there is API Windows API to turn it on? > Also a default. The Windows API can't be removed and retain binary compatibility, but we can make it do nothing. It's unused. The default is on on iOS, and I preserved this behavior.
EWS Watchlist
Comment 5 2018-09-13 02:40:38 PDT
Comment on attachment 349554 [details] Patch Attachment 349554 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9201109 New failing tests: fast/animation/css-animation-resuming-when-visible-with-style-change2.html
EWS Watchlist
Comment 6 2018-09-13 02:40:40 PDT
Created attachment 349648 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Alex Christensen
Comment 7 2018-09-25 12:05:58 PDT
This is actually used :(
Note You need to log in before you can comment on or make changes to this bug.