[IntersectionObserver] Implement rootMargin expansion

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Ali Juma]

Expand the root intersection rectangle by the observer's rootMargin.

[Ali Juma]

Created attachment 349467 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 349467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349467&action=review

> Source/WebCore/dom/Document.cpp:7498
> +    localRootBounds.move(-rootMarginFloatBox.left(), -rootMarginFloatBox.top());
> +    localRootBounds.expand(rootMarginFloatBox.left() + rootMarginFloatBox.right(), rootMarginFloatBox.top() + rootMarginFloatBox.bottom());

It feels like there should be a cleaner way to do this.

[Ali Juma]

Created attachment 349548 [details]
Patch for landing

[Ali Juma]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 349467 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349467&action=review
> 
> > Source/WebCore/dom/Document.cpp:7498
> > +    localRootBounds.move(-rootMarginFloatBox.left(), -rootMarginFloatBox.top());
> > +    localRootBounds.expand(rootMarginFloatBox.left() + rootMarginFloatBox.right(), rootMarginFloatBox.top() + rootMarginFloatBox.bottom());
> 
> It feels like there should be a cleaner way to do this.

LayoutRect::expand has an overload that takes a LayoutBoxExtent, so I added a version of FloatRect::expand that takes a FloatBoxExtent.

[WebKit Commit Bot]

Comment on attachment 349548 [details]
Patch for landing

Clearing flags on attachment: 349548

Committed r235943: <https://trac.webkit.org/changeset/235943>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44386685>