Bug 189432

Summary: [iOS] Make WKWebView become the first responder to support testing key presses to non-editable elements
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: jeremyj-wk, jonlee, lforschler, megan_gardner, mitz, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: iOS 11   
Bug Depends on:    
Bug Blocks: 190571, 189389    
Attachments:
Description Flags
Patch and layout test none

Daniel Bates
Reported 2018-09-07 14:12:16 PDT
It is not possible to simulate hardware keyboard key presses outside of a content-editable element. We should support this.
Attachments
Patch and layout test (16.78 KB, patch)
2018-09-07 14:22 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-09-07 14:22:32 PDT
Created attachment 349190 [details] Patch and layout test
Simon Fraser (smfr)
Comment 2 2018-09-07 15:58:34 PDT
Comment on attachment 349190 [details] Patch and layout test View in context: https://bugs.webkit.org/attachment.cgi?id=349190&action=review > Tools/ChangeLog:9 > + Make the WKWebView become the first responder immediately without the need to focus an editable > + element. This allows us to test that DOM keyboard events are dispatched to non-editable elements. Does the view become first responder in MobileSafari/SFSafariViewController?
Daniel Bates
Comment 3 2018-09-07 16:07:04 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 349190 [details] > Patch and layout test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=349190&action=review > > > Tools/ChangeLog:9 > > + Make the WKWebView become the first responder immediately without the need to focus an editable > > + element. This allows us to test that DOM keyboard events are dispatched to non-editable elements. > > Does the view become first responder in MobileSafari/SFSafariViewController? Yes.
Daniel Bates
Comment 4 2018-09-10 13:55:28 PDT
Comment on attachment 349190 [details] Patch and layout test Clearing flags on attachment: 349190 Committed r235858: <https://trac.webkit.org/changeset/235858>
Daniel Bates
Comment 5 2018-09-10 13:55:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-09-10 13:56:28 PDT
<rdar://problem/44316037>
Note You need to log in before you can comment on or make changes to this bug.