Bug 189380

Summary: Improper speculation type for Math.pow(NaN, 0) in Abstract Interpreter
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2018-09-06 15:52:58 PDT
Given that Math.pow(NaN, 0) gives the result of 1, the computed SpeculatedType for ArithPow(NaN, non-NaN) should include Double values.
Attachments
Patch (2.67 KB, patch)
2018-09-06 16:00 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2018-09-06 15:53:24 PDT
<rdar://problem/42908665>
Michael Saboff
Comment 2 2018-09-06 16:00:21 PDT
Created attachment 349086 [details] Patch
Saam Barati
Comment 3 2018-09-06 16:18:30 PDT
Comment on attachment 349086 [details] Patch Let's keep an eye on perf bots after this to ensure this doesn't hurt perf anywhere
Michael Saboff
Comment 4 2018-09-06 16:19:25 PDT
(In reply to Saam Barati from comment #3) > Comment on attachment 349086 [details] > Patch > > Let's keep an eye on perf bots after this to ensure this doesn't hurt perf > anywhere Good idea.
WebKit Commit Bot
Comment 5 2018-09-06 16:44:57 PDT
Comment on attachment 349086 [details] Patch Clearing flags on attachment: 349086 Committed r235765: <https://trac.webkit.org/changeset/235765>
WebKit Commit Bot
Comment 6 2018-09-06 16:44:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.