Bug 189372

Summary: Web Inspector: Dark Mode : Sidebar filter input text color wrong color when focus lost
Product: WebKit Reporter: Jamal Nasser <jamaln>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: bburg, hi, inspector-bugzilla-changes, jamaln, joepeck
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot without patch
none
Screenshot with patch
none
Patch none

Jamal Nasser
Reported 2018-09-06 14:22:41 PDT
Created attachment 349071 [details] Screenshot without patch The text color switches to black when focus is lost from the search fields in the sidebar
Attachments
Screenshot without patch (381.50 KB, image/png)
2018-09-06 14:22 PDT, Jamal Nasser 		no flags
Details
Screenshot with patch (379.92 KB, image/png)
2018-09-06 14:29 PDT, Jamal Nasser 		no flags
Details
Patch (1.62 KB, patch)
2018-09-06 14:37 PDT, Jamal Nasser 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jamal Nasser
Comment 1 2018-09-06 14:29:40 PDT
Created attachment 349073 [details] Screenshot with patch
Jamal Nasser
Comment 2 2018-09-06 14:37:42 PDT
Created attachment 349077 [details] Patch
Devin Rousso
Comment 3 2018-09-11 11:36:25 PDT
I'm not seeing the issue on my machine. Are you up to date in your repo?
Jamal Nasser
Comment 4 2018-09-11 14:44:17 PDT
That's odd. I just checked on revision: 235912 and the bug is still there for me. It might be because I'm forcing Dark Mode in MediaQueryEvaluator.cpp and not actually running Mojave?
Blaze Burg
Comment 5 2018-09-11 14:56:57 PDT
(In reply to Jamal Nasser from comment #4) > That's odd. I just checked on revision: 235912 and the bug is still there > for me. > It might be because I'm forcing Dark Mode in MediaQueryEvaluator.cpp and not > actually running Mojave? Form controls need system support added in Mojave to render in Dark Mode. If you are modifying WK code or running an earlier version of macOS, there are no guarantees about what will happen in dark mode code paths.
Jamal Nasser
Comment 6 2018-09-11 15:13:12 PDT
Ah, thanks for the clarification
Joseph Pecoraro
Comment 7 2018-09-12 11:48:56 PDT
Comment on attachment 349077 [details] Patch Clearing r? given this bug is closed.
Note You need to log in before you can comment on or make changes to this bug.