Bug 18935 – [Gtk] Plugin Load crashes with NP_FULL mode

• Component: Plug-ins
• Status: RESOLVED FIXED

[Sriram Neelakandan]

NP_EMBED mode plugin works fine,
when the same plugin is loaded with the URL, it crashes at 


void PluginView::didReceiveData(const char* data, int length)
{
    ASSERT(m_loadManually);
    ASSERT(m_manualStream);
    m_manualStream->didReceiveData(0, data, length);
}

On further DEBUG i found m_manualStream is NULL.

Reason: PluginView::didReceiveResponse does not get called, from FrameLoaderClient::commitedLoad.

FrameLoaderCleint::m_hasSentResponseToPlugin is not initialized and has some JUNK data. So the following check fails :
        if (!m_hasSentResponseToPlugin) {
            m_pluginView->didReceiveResponse(loader->response());
            m_hasSentResponseToPlugin = true;
        }

I will attach a patch shortly to initialize m_hasSentResponseToPlugin

[Sriram Neelakandan]

Created attachment 21007 [details]
Fix for NP_FULL crash

This uninitialized variable caused a crash as explained in the bug

[Sriram Neelakandan]

Created attachment 21008 [details]
Re-init variable in redirectDataToPlugin

Not sure if this one is required.
May be some one who knows the code better can take this in if required.

[marcoil]

Created attachment 21017 [details]
Fix the bug for Qt

This is the same fix applied to the Qt port.

[Simon Hausmann]

Comment on attachment 21017 [details]
Fix the bug for Qt

#21017 landed in r33001.

[marcoil]

The Gtk patches haven't landed yet, so I think this one should be re-opened.

[Pierre-Luc Beaudoin]

Reopening for the Gtk patch.

[Alp Toker]

Landed in r34121.