Bug 189347

Summary: Move regress-189185.js under JSTests/wasm.
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, realdawei, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=189312
Attachments:
Description Flags
Patch
none
Patch
mark.lam: review-
patch for landing. commit-queue: commit-queue-

Dominik Inführ
Reported 2018-09-06 07:33:13 PDT
Disable test when WebAssembly not enabled
Attachments
Patch (2.11 KB, patch)
2018-09-06 07:35 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (2.12 KB, patch)
2018-09-06 07:38 PDT, Dominik Inführ 		mark.lam: review-
DetailsFormatted DiffDiff
patch for landing. (1.90 KB, patch)
2018-09-06 11:49 PDT, Mark Lam 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2018-09-06 07:35:56 PDT
Created attachment 349022 [details] Patch
Dominik Inführ
Comment 2 2018-09-06 07:38:42 PDT
Created attachment 349023 [details] Patch
Saam Barati
Comment 3 2018-09-06 07:47:43 PDT
Comment on attachment 349023 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349023&action=review > JSTests/stress/regress-189185.js:1 > +//@ skip if !isWebAssemblyEnabled Why not move this test into the Wasm test directory?
Mark Lam
Comment 4 2018-09-06 09:42:37 PDT
Comment on attachment 349023 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349023&action=review >> JSTests/stress/regress-189185.js:1 >> +//@ skip if !isWebAssemblyEnabled > > Why not move this test into the Wasm test directory? I agree with Saam. I should have put this test in JSTests/wasm directory. I just wasn't aware of that option at the time. Let's move the test there instead. Thanks.
Mark Lam
Comment 5 2018-09-06 10:59:52 PDT
Since Dominik hasn't responded yet, and this issue seems to be creating problems with some of our internal testing as well, I'll go ahead and implement the fix.
Mark Lam
Comment 6 2018-09-06 11:49:07 PDT
Created attachment 349048 [details] patch for landing.
WebKit Commit Bot
Comment 7 2018-09-06 12:47:23 PDT
Comment on attachment 349048 [details] patch for landing. Rejecting attachment 349048 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 349048, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/JSTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/9117011
Mark Lam
Comment 8 2018-09-06 12:59:52 PDT
Landed in r235751: <http://trac.webkit.org/r235751>.
Radar WebKit Bug Importer
Comment 9 2018-09-06 13:02:56 PDT
<rdar://problem/44193122>
Dominik Inführ
Comment 10 2018-09-07 01:27:07 PDT
Thanks for fixing that!
Note You need to log in before you can comment on or make changes to this bug.