Bug 189332

Summary:

Enable world leaks by default for Mac WK2

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Joseph Pecoraro <joepeck>

Status:

NEW

Severity:

Normal

CC:

achristensen, aestes, ap, darin, dbates, ews-watchlist, glenn, jbedard, joepeck, mkwst, rniwa, rreno, ryanhaddad, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

186214

Attachments:

Description	Flags
Patch	none
Patch (with other possibly necessary changes)	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Patch	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews105 for mac-sierra-wk2	none

Simon Fraser (smfr)

Reported 2018-09-05 19:57:01 PDT

Enable world leaks by default for Mac WK2

Attachments
Patch (39.20 KB, patch) 2018-09-05 19:58 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (with other possibly necessary changes) (64.94 KB, patch) 2018-09-05 20:10 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (39.96 KB, patch) 2018-09-05 20:10 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (41.80 KB, patch) 2018-09-06 08:02 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (41.75 KB, patch) 2018-09-06 17:32 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (41.47 KB, patch) 2018-09-06 19:06 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (41.49 KB, patch) 2018-09-06 19:38 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (41.49 KB, patch) 2018-09-06 21:43 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (41.46 KB, patch) 2018-09-07 14:15 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.12 MB, application/zip) 2018-09-07 15:27 PDT, EWS Watchlist	no flags	Details
Patch (47.15 KB, patch) 2018-09-07 19:18 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.97 MB, application/zip) 2018-09-07 20:15 PDT, EWS Watchlist	no flags	Details
Patch (48.50 KB, patch) 2018-09-07 22:09 PDT, Simon Fraser (smfr)	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.05 MB, application/zip) 2018-09-07 23:23 PDT, EWS Watchlist	no flags	Details
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-09-05 19:58:58 PDT Comment hidden (obsolete)

Created attachment 348996 [details] Patch

Simon Fraser (smfr)

Comment 2 2018-09-05 20:10:18 PDT Comment hidden (obsolete)

Created attachment 348997 [details] Patch (with other possibly necessary changes)

Simon Fraser (smfr)

Comment 3 2018-09-05 20:10:43 PDT Comment hidden (obsolete)

Created attachment 348998 [details] Patch

Simon Fraser (smfr)

Comment 4 2018-09-06 08:02:32 PDT Comment hidden (obsolete)

Created attachment 349024 [details] Patch

Alexey Proskuryakov

Comment 5 2018-09-06 13:50:00 PDT

Looks like this breaks EWS, as it should have marked these patches as a failure.

Simon Fraser (smfr)

Comment 6 2018-09-06 17:32:28 PDT Comment hidden (obsolete)

Created attachment 349099 [details] Patch

Simon Fraser (smfr)

Comment 7 2018-09-06 19:06:41 PDT Comment hidden (obsolete)

Created attachment 349102 [details] Patch

Simon Fraser (smfr)

Comment 8 2018-09-06 19:38:33 PDT Comment hidden (obsolete)

Created attachment 349104 [details] Patch

Simon Fraser (smfr)

Comment 9 2018-09-06 21:43:43 PDT Comment hidden (obsolete)

Created attachment 349112 [details] Patch

Simon Fraser (smfr)

Comment 10 2018-09-07 14:15:36 PDT

Created attachment 349189 [details] Patch

EWS Watchlist

Comment 11 2018-09-07 15:27:31 PDT

Comment on attachment 349189 [details] Patch Attachment 349189 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9133425 New failing tests: fast/events/context-no-deselect.html fast/css3-text/css3-text-decoration/repaint/underline-outside-of-layout-rect.html fast/shadow-dom/fullscreen-in-shadow-webkitCurrentFullScreenElement.html svg/batik/filters/filterRegions.svg svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg fullscreen/video-controls-override.html editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html fast/events/mousedown-inside-dragstart-should-not-cause-crash.html svg/batik/text/smallFonts.svg swipe/pushState-programmatic-back-while-swiping-crash.html editing/selection/drag-in-iframe.html media/controls/picture-in-picture.html pointer-lock/locked-element-removed-from-dom.html svg/batik/paints/patternPreserveAspectRatioA.svg imported/w3c/web-platform-tests/payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https.html editing/selection/context-menu-text-selection.html

EWS Watchlist

Comment 12 2018-09-07 15:27:33 PDT

Created attachment 349207 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Simon Fraser (smfr)

Comment 13 2018-09-07 19:18:36 PDT

Created attachment 349231 [details] Patch

EWS Watchlist

Comment 14 2018-09-07 20:15:03 PDT

Comment on attachment 349231 [details] Patch Attachment 349231 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9136431 New failing tests: media/modern-media-controls/seek-backward-support/seek-backward-support.html editing/selection/context-menu-text-selection-lookup.html svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg media/controls/fullscreen-button-inline-layout.html editing/pasteboard/drag-drop-to-data-url.html fast/events/dragging-mouse-moves.html svg/batik/text/textAnchor.svg fullscreen/video-controls-drag.html swipe/pushState-programmatic-back-while-swiping-crash.html editing/selection/drag-in-iframe.html fast/shadow-dom/fullscreen-in-shadow-fullscreenElement.html pointer-lock/lock-lost-on-navigation.html svg/batik/paints/patternRegionA.svg

EWS Watchlist

Comment 15 2018-09-07 20:15:05 PDT

Created attachment 349233 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Simon Fraser (smfr)

Comment 16 2018-09-07 22:09:03 PDT

Created attachment 349241 [details] Patch

EWS Watchlist

Comment 17 2018-09-07 23:23:50 PDT

Comment on attachment 349241 [details] Patch Attachment 349241 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9137950 New failing tests: media/controls/showControlsButton.html editing/pasteboard/drag-drop-input-in-svg.svg editing/selection/crash-on-drag-with-mutation-events.html http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html svg/batik/text/textFeatures.svg svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg fullscreen/parent-flow-inline-with-block-child.html fast/events/drag-and-drop-autoscroll-inner-frame.html media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html svg/batik/paints/patternRegions.svg pointer-lock/lock-lost-on-alert.html editing/selection/context-menu-on-text.html

EWS Watchlist

Comment 18 2018-09-07 23:23:52 PDT

Created attachment 349250 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Alex Christensen

Comment 19 2021-11-01 12:52:05 PDT

Comment on attachment 349241 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.

Note You need to log in before you can comment on or make changes to this bug.