Summary: | [iOS] uiController.typeCharacterUsingHardwareKeyboard("`", ...) dispatches DOM key events for ~ | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | lforschler, rniwa, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | iOS 11 | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=189327 https://bugs.webkit.org/show_bug.cgi?id=189388 https://bugs.webkit.org/show_bug.cgi?id=189436 |
||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 190571 | ||||||||
Attachments: |
|
Likely relevant: hidUsageCodeForCharacter (and nearby code) in HIDEventGenerator.mm. (In reply to Wenson Hsieh from comment #1) > Likely relevant: hidUsageCodeForCharacter (and nearby code) in > HIDEventGenerator.mm. ...and shouldWrapWithShiftKeyEventForCharacter, which wraps both '`' and '~' with shift key events :| Created attachment 349210 [details]
Patch and layout test
Comment on attachment 349210 [details] Patch and layout test Clearing flags on attachment: 349210 Committed r235818: <https://trac.webkit.org/changeset/235818> All reviewed patches have been landed. Closing bug. |
Created attachment 348975 [details] Test case Today when writing a layout test for iOS I noticed that using uiController.typeCharacterUsingHardwareKeyboard("`", ...) to simulate typing the grave accent (`) causes DOM key events for tilda (~) to be emitted. Steps to reproduce: Run the attached test case, test.html, in iOS WebKitTestRunner. Looking at the type and key properties in the fired key events I see: type: keydown, key: ~ type: keypress, key: ~ type: keyup, key: ~ But I should see: type: keydown, key: ` type: keypress, key: ` type: keyup, key: `