Bug 189325

Summary: [iOS] uiController.typeCharacterUsingHardwareKeyboard("`", ...) dispatches DOM key events for ~
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler, rniwa, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: iOS 11   
See Also: https://bugs.webkit.org/show_bug.cgi?id=189327
https://bugs.webkit.org/show_bug.cgi?id=189388
https://bugs.webkit.org/show_bug.cgi?id=189436
Bug Depends on:    
Bug Blocks: 190571    
Attachments:
Description Flags
Test case
none
Patch and layout test none

Daniel Bates
Reported 2018-09-05 16:05:07 PDT
Created attachment 348975 [details] Test case Today when writing a layout test for iOS I noticed that using uiController.typeCharacterUsingHardwareKeyboard("`", ...) to simulate typing the grave accent (`) causes DOM key events for tilda (~) to be emitted. Steps to reproduce: Run the attached test case, test.html, in iOS WebKitTestRunner. Looking at the type and key properties in the fired key events I see: type: keydown, key: ~ type: keypress, key: ~ type: keyup, key: ~ But I should see: type: keydown, key: ` type: keypress, key: ` type: keyup, key: `
Attachments
Test case (2.44 KB, text/html)
2018-09-05 16:05 PDT, Daniel Bates 		no flags
Details
Patch and layout test (4.96 KB, patch)
2018-09-07 15:47 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-09-05 16:54:39 PDT
Likely relevant: hidUsageCodeForCharacter (and nearby code) in HIDEventGenerator.mm.
Wenson Hsieh
Comment 2 2018-09-05 16:57:43 PDT
(In reply to Wenson Hsieh from comment #1) > Likely relevant: hidUsageCodeForCharacter (and nearby code) in > HIDEventGenerator.mm. ...and shouldWrapWithShiftKeyEventForCharacter, which wraps both '`' and '~' with shift key events :|
Daniel Bates
Comment 3 2018-09-07 15:47:08 PDT
Created attachment 349210 [details] Patch and layout test
Daniel Bates
Comment 4 2018-09-07 16:09:20 PDT
Comment on attachment 349210 [details] Patch and layout test Clearing flags on attachment: 349210 Committed r235818: <https://trac.webkit.org/changeset/235818>
Daniel Bates
Comment 5 2018-09-07 16:09:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-09-07 16:10:33 PDT
<rdar://problem/44243118>
Note You need to log in before you can comment on or make changes to this bug.