Bug 189303

Summary:

Update idlharness.js and webidl2.js.

Product:

WebKit

Reporter:

Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>

Component:

Tools / Tests

Assignee:

Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, cdumez, commit-queue, ews-watchlist, lforschler, realdawei, rniwa, ryanhaddad, tsavell, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews117 for mac-sierra	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews112 for mac-sierra	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews117 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none

Ms2ger (he/him; ⌚ UTC+1/+2)

Reported 2018-09-05 06:37:47 PDT

Attachments
Patch (583.86 KB, patch) 2018-09-05 06:42 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (1.84 MB, application/zip) 2018-09-05 07:34 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.16 MB, application/zip) 2018-09-05 07:46 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (1.54 MB, application/zip) 2018-09-05 07:57 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.09 MB, application/zip) 2018-09-05 08:28 PDT, EWS Watchlist	no flags	Details
Patch (758.01 KB, patch) 2018-09-05 08:57 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews112 for mac-sierra (3.23 MB, application/zip) 2018-09-05 10:42 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews100 for mac-sierra (2.65 MB, application/zip) 2018-09-05 10:43 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.62 MB, application/zip) 2018-09-05 10:45 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.75 MB, application/zip) 2018-09-05 10:58 PDT, EWS Watchlist	no flags	Details
Patch (896.35 KB, patch) 2018-09-06 01:55 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.38 MB, application/zip) 2018-09-06 03:01 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.01 MB, application/zip) 2018-09-06 03:13 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.47 MB, application/zip) 2018-09-06 03:56 PDT, EWS Watchlist	no flags	Details
Patch (908.11 KB, patch) 2018-09-06 04:05 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.32 MB, application/zip) 2018-09-06 05:10 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.54 MB, application/zip) 2018-09-06 05:11 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.55 MB, application/zip) 2018-09-06 06:04 PDT, EWS Watchlist	no flags	Details
Patch (969.87 KB, patch) 2018-09-06 08:08 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.32 MB, application/zip) 2018-09-06 09:16 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.88 MB, application/zip) 2018-09-06 10:00 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.35 MB, application/zip) 2018-09-06 10:08 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (3.61 MB, application/zip) 2018-09-06 13:33 PDT, EWS Watchlist	no flags	Details
Patch (1012.76 KB, patch) 2018-09-07 01:38 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.56 MB, application/zip) 2018-09-07 02:32 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.04 MB, application/zip) 2018-09-07 02:34 PDT, EWS Watchlist	no flags	Details
Patch (1.01 MB, patch) 2018-09-07 03:08 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 1 2018-09-05 06:38:55 PDT

This should fix the "ReferenceError: Can't find variable: idl_test" errors in LayoutTests/imported/w3c/web-platform-tests/intersection-observer/idlharness.window.js LayoutTests/imported/w3c/web-platform-tests/payment-request/idlharness.https.window.js LayoutTests/imported/w3c/web-platform-tests/xhr/idlharness.any.js

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 2 2018-09-05 06:42:00 PDT

Created attachment 348908 [details] Patch

EWS Watchlist

Comment 3 2018-09-05 07:34:28 PDT

Comment on attachment 348908 [details] Patch Attachment 348908 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9101800 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 4 2018-09-05 07:34:30 PDT

Created attachment 348918 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-09-05 07:46:03 PDT

Comment on attachment 348908 [details] Patch Attachment 348908 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9101902 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 6 2018-09-05 07:46:05 PDT

Created attachment 348920 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-09-05 07:57:32 PDT

Comment on attachment 348908 [details] Patch Attachment 348908 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9101901 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 8 2018-09-05 07:57:34 PDT

Created attachment 348922 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-09-05 08:28:28 PDT

Comment on attachment 348908 [details] Patch Attachment 348908 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9101961 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 10 2018-09-05 08:28:29 PDT

Created attachment 348924 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 11 2018-09-05 08:57:37 PDT

Created attachment 348928 [details] Patch

EWS Watchlist

Comment 12 2018-09-05 10:42:55 PDT

Comment on attachment 348928 [details] Patch Attachment 348928 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9103354 New failing tests: imported/w3c/web-platform-tests/intersection-observer/idlharness.window.html imported/w3c/web-platform-tests/hr-time/idlharness.html imported/w3c/web-platform-tests/FileAPI/idlharness.html imported/w3c/web-platform-tests/FileAPI/idlharness.worker.html imported/w3c/web-platform-tests/media-source/interfaces.html imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/workers/interfaces.worker.html imported/w3c/web-platform-tests/xhr/idlharness.any.html imported/w3c/web-platform-tests/xhr/idlharness.any.worker.html imported/w3c/web-platform-tests/IndexedDB/interfaces.any.html imported/w3c/web-platform-tests/web-share/idlharness.https.html

EWS Watchlist

Comment 13 2018-09-05 10:42:57 PDT

Created attachment 348939 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 14 2018-09-05 10:43:20 PDT

Comment on attachment 348928 [details] Patch Attachment 348928 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9103578 New failing tests: imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/idl-test.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiodestinationnode-interface/idl-test.html imported/w3c/web-platform-tests/FileAPI/idlharness.html imported/w3c/web-platform-tests/FileAPI/idlharness.worker.html imported/w3c/web-platform-tests/intersection-observer/idlharness.window.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/idl-test.html imported/w3c/web-platform-tests/media-source/interfaces.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/idl-test.html imported/w3c/web-platform-tests/hr-time/idlharness.html imported/w3c/web-platform-tests/workers/interfaces.worker.html imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/xhr/idlharness.any.html imported/w3c/web-platform-tests/xhr/idlharness.any.worker.html imported/w3c/web-platform-tests/dom/interfaces.html imported/w3c/web-platform-tests/IndexedDB/interfaces.any.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/idl-test.html imported/w3c/web-platform-tests/web-share/idlharness.https.html

EWS Watchlist

Comment 15 2018-09-05 10:43:22 PDT

Created attachment 348940 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 16 2018-09-05 10:45:24 PDT

Comment on attachment 348928 [details] Patch Attachment 348928 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9103551 New failing tests: imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/idl-test.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiodestinationnode-interface/idl-test.html imported/w3c/web-platform-tests/media-source/interfaces.html imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/idl-test.html imported/w3c/web-platform-tests/credential-management/idl.https.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html imported/w3c/web-platform-tests/payment-request/idlharness.https.window.html imported/w3c/web-platform-tests/hr-time/idlharness.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-window.https.html imported/w3c/web-platform-tests/xhr/idlharness.any.worker.html imported/w3c/web-platform-tests/web-share/idlharness.https.html imported/w3c/web-platform-tests/FileAPI/idlharness.worker.html imported/w3c/web-platform-tests/intersection-observer/idlharness.window.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/idl-test.html css3/filters/backdrop/add-remove-add-backdrop-filter.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/idl-test.html imported/w3c/web-platform-tests/IndexedDB/interfaces.any.worker.html imported/w3c/web-platform-tests/workers/interfaces.worker.html imported/w3c/web-platform-tests/xhr/idlharness.any.html imported/w3c/web-platform-tests/dom/interfaces.html http/wpt/credential-management/idl.https.html imported/w3c/web-platform-tests/FileAPI/idlharness.html http/wpt/webauthn/idl.https.html imported/w3c/web-platform-tests/IndexedDB/interfaces.any.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all.html

EWS Watchlist

Comment 17 2018-09-05 10:45:26 PDT

Created attachment 348941 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 18 2018-09-05 10:58:13 PDT

Comment on attachment 348928 [details] Patch Attachment 348928 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9103389 New failing tests: imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/idl-test.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiodestinationnode-interface/idl-test.html imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/idl-test.html imported/w3c/web-platform-tests/credential-management/idl.https.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html imported/w3c/web-platform-tests/payment-request/idlharness.https.window.html imported/w3c/web-platform-tests/hr-time/idlharness.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-window.https.html imported/w3c/web-platform-tests/xhr/idlharness.any.worker.html imported/w3c/web-platform-tests/web-share/idlharness.https.html imported/w3c/web-platform-tests/FileAPI/idlharness.worker.html imported/w3c/web-platform-tests/intersection-observer/idlharness.window.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/idl-test.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/idl-test.html imported/w3c/web-platform-tests/IndexedDB/interfaces.any.worker.html imported/w3c/web-platform-tests/workers/interfaces.worker.html imported/w3c/web-platform-tests/xhr/idlharness.any.html imported/w3c/web-platform-tests/dom/interfaces.html http/wpt/credential-management/idl.https.html imported/w3c/web-platform-tests/FileAPI/idlharness.html http/wpt/webauthn/idl.https.html imported/w3c/web-platform-tests/IndexedDB/interfaces.any.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all.html

EWS Watchlist

Comment 19 2018-09-05 10:58:15 PDT

Created attachment 348944 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 20 2018-09-06 01:55:11 PDT

Created attachment 349009 [details] Patch

EWS Watchlist

Comment 21 2018-09-06 03:01:56 PDT

Comment on attachment 349009 [details] Patch Attachment 349009 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9112126 New failing tests: imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/idl-test.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiodestinationnode-interface/idl-test.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/idl-test.html imported/w3c/web-platform-tests/media-source/interfaces.html imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/idl-test.html imported/w3c/web-platform-tests/hr-time/idlharness.html

EWS Watchlist

Comment 22 2018-09-06 03:01:58 PDT

Created attachment 349011 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 23 2018-09-06 03:13:37 PDT

Comment on attachment 349009 [details] Patch Attachment 349009 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9112142 New failing tests: imported/w3c/web-platform-tests/payment-request/idlharness.https.window.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/idl-test.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiodestinationnode-interface/idl-test.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html http/wpt/credential-management/idl.https.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/idl-test.html imported/w3c/web-platform-tests/media-source/interfaces.html imported/w3c/web-platform-tests/hr-time/idlharness.html imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/IndexedDB/interfaces.any.worker.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-window.https.html imported/w3c/web-platform-tests/credential-management/idl.https.html http/wpt/webauthn/idl.https.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/idl-test.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all.html

EWS Watchlist

Comment 24 2018-09-06 03:13:39 PDT

Created attachment 349013 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 25 2018-09-06 03:56:05 PDT

Comment on attachment 349009 [details] Patch Attachment 349009 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9112200 New failing tests: imported/w3c/web-platform-tests/payment-request/idlharness.https.window.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/idl-test.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiodestinationnode-interface/idl-test.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html http/wpt/credential-management/idl.https.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/idl-test.html imported/w3c/web-platform-tests/hr-time/idlharness.html imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/IndexedDB/interfaces.any.worker.html imported/w3c/web-platform-tests/web-share/idlharness.https.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-window.https.html imported/w3c/web-platform-tests/credential-management/idl.https.html http/wpt/webauthn/idl.https.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/idl-test.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all.html

EWS Watchlist

Comment 26 2018-09-06 03:56:07 PDT

Created attachment 349014 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 27 2018-09-06 04:05:17 PDT

Created attachment 349015 [details] Patch

EWS Watchlist

Comment 28 2018-09-06 05:10:48 PDT

Comment on attachment 349015 [details] Patch Attachment 349015 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9112875 New failing tests: imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/idl-test.html imported/w3c/web-platform-tests/media-source/interfaces.html imported/w3c/web-platform-tests/xhr/interfaces.html

EWS Watchlist

Comment 29 2018-09-06 05:10:49 PDT

Created attachment 349017 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 30 2018-09-06 05:11:31 PDT

Comment on attachment 349015 [details] Patch Attachment 349015 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9112837 New failing tests: imported/w3c/web-platform-tests/payment-request/idlharness.https.window.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/idl-test.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html http/wpt/credential-management/idl.https.html imported/w3c/web-platform-tests/media-source/interfaces.html imported/w3c/web-platform-tests/IndexedDB/interfaces.any.worker.html imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-window.https.html imported/w3c/web-platform-tests/credential-management/idl.https.html http/wpt/webauthn/idl.https.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all.html

EWS Watchlist

Comment 31 2018-09-06 05:11:33 PDT

Created attachment 349018 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 32 2018-09-06 06:04:09 PDT

Comment on attachment 349015 [details] Patch Attachment 349015 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9112949 New failing tests: imported/w3c/web-platform-tests/payment-request/idlharness.https.window.html imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/idl-test.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html http/wpt/credential-management/idl.https.html imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/IndexedDB/interfaces.any.worker.html imported/w3c/web-platform-tests/web-share/idlharness.https.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-window.https.html imported/w3c/web-platform-tests/credential-management/idl.https.html http/wpt/webauthn/idl.https.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all.html

EWS Watchlist

Comment 33 2018-09-06 06:04:11 PDT

Created attachment 349019 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 34 2018-09-06 08:08:46 PDT

Created attachment 349025 [details] Patch Sorry for the spam, everyone; I thought this would take fewer iterations.

youenn fablet

Comment 35 2018-09-06 08:44:11 PDT

No problem, thanks for doing this! If one issue is updating the test expectations, the script Tools/Scripts/update-test-expectations-from-bugzilla might help.

EWS Watchlist

Comment 36 2018-09-06 09:16:03 PDT

Comment on attachment 349025 [details] Patch Attachment 349025 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9114740 New failing tests: imported/w3c/web-platform-tests/media-source/interfaces.html imported/w3c/web-platform-tests/xhr/interfaces.html

EWS Watchlist

Comment 37 2018-09-06 09:16:05 PDT

Created attachment 349031 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 38 2018-09-06 10:00:33 PDT

Comment on attachment 349025 [details] Patch Attachment 349025 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9115025 New failing tests: imported/w3c/web-platform-tests/media-source/interfaces.html http/wpt/webauthn/idl.https.html imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all.html

EWS Watchlist

Comment 39 2018-09-06 10:00:35 PDT

Created attachment 349036 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 40 2018-09-06 10:08:02 PDT

Comment on attachment 349025 [details] Patch Attachment 349025 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9114819 New failing tests: imported/w3c/web-platform-tests/xhr/interfaces.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all.html imported/w3c/web-platform-tests/web-share/idlharness.https.html imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html http/wpt/webauthn/idl.https.html

EWS Watchlist

Comment 41 2018-09-06 10:08:04 PDT

Created attachment 349037 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 42 2018-09-06 13:33:00 PDT

Comment on attachment 349025 [details] Patch Attachment 349025 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9116989 New failing tests: imported/w3c/web-platform-tests/media-source/interfaces.html imported/w3c/web-platform-tests/xhr/interfaces.html

EWS Watchlist

Comment 43 2018-09-06 13:33:02 PDT

Created attachment 349062 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 44 2018-09-07 01:38:57 PDT

Created attachment 349126 [details] Patch

EWS Watchlist

Comment 45 2018-09-07 02:32:01 PDT

Comment on attachment 349126 [details] Patch Attachment 349126 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9125076 New failing tests: imported/w3c/web-platform-tests/media-source/interfaces.html

EWS Watchlist

Comment 46 2018-09-07 02:32:04 PDT

Created attachment 349129 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 47 2018-09-07 02:34:32 PDT

Comment on attachment 349126 [details] Patch Attachment 349126 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9125054 New failing tests: imported/w3c/web-platform-tests/media-source/interfaces.html

EWS Watchlist

Comment 48 2018-09-07 02:34:34 PDT

Created attachment 349130 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 49 2018-09-07 03:08:49 PDT

Created attachment 349133 [details] Patch Youenn: I didn't flag for review since you already reviewed earlier, but feel free to take another look. If I don't hear anything from you, I'll land it early next week.

WebKit Commit Bot

Comment 50 2018-09-11 01:15:10 PDT

Comment on attachment 349133 [details] Patch Clearing flags on attachment: 349133 Committed r235889: <https://trac.webkit.org/changeset/235889>

WebKit Commit Bot

Comment 51 2018-09-11 01:15:12 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 52 2018-09-11 01:16:39 PDT

<rdar://problem/44334400>

Truitt Savell

Comment 53 2018-09-11 08:57:09 PDT

Looks like https://trac.webkit.org/changeset/235889/webkit has caused imported/w3c/web-platform-tests/css/cssom/interfaces.html to be a failure across all bots. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcssom%2Finterfaces.html Diff: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r235889%20(7903)/imported/w3c/web-platform-tests/css/cssom/interfaces-pretty-diff.html

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 54 2018-09-11 09:04:45 PDT

Looks like it simply needs a rebaseline; not sure why I missed it here. If nobody else gets to it first, I'll try to fix it tomorrow.

Truitt Savell

Comment 55 2018-09-11 09:15:49 PDT

Sense this has made all the bots red we need a fix asap or we will need to roll the change out until there is a fix.

Chris Dumez

Comment 56 2018-09-11 09:18:04 PDT

(In reply to Truitt Savell from comment #55) > Sense this has made all the bots red we need a fix asap or we will need to > roll the change out until there is a fix. Truitt, would you be able to help with rebaselining the test in question instead?

Chris Dumez

Comment 57 2018-09-11 09:24:50 PDT

(In reply to Chris Dumez from comment #56) > (In reply to Truitt Savell from comment #55) > > Sense this has made all the bots red we need a fix asap or we will need to > > roll the change out until there is a fix. > > Truitt, would you be able to help with rebaselining the test in question > instead? Nevermind, I rebaselined the test in <https://trac.webkit.org/changeset/235896>.

Truitt Savell

Comment 58 2018-09-11 13:20:35 PDT

It also seems that High Sierra Leaks is failing with an exception during layout tests. The log shows that most of the tests run up until the imported/ directory which this change effected. Logs: https://build.webkit.org/builders/Apple%20High%20Sierra%20%28Leaks%29/builds/5580/steps/layout-test/logs/stdio Test Failure: https://build.webkit.org/builders/Apple%20High%20Sierra%20%28Leaks%29/builds/5580 I have not been able to reproduce yet to confirm. Excerpt: 02:25:40.053 1959 worker/0 imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https.html passed 02:25:40.155 1959 worker/0 imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.sharedworker.html passed 02:25:39.925 1965 Checking for leaks in DumpRenderTree 02:25:40.178 1965 "Tools/Scripts/run-leaks --exclude-callstack=WTF::BitVector::OutOfLineBits::create --exclude-callstack=WTF::BitVector::resizeOutOfLine --exclude-callstack=WebCore::createPrivateStorageSession --exclude-callstack=CIDeviceManagerStartMonitoring --exclude-callstack=NSSpellChecker init --exclude-callstack=NSColor controlHighlightColor --output-file=/Volumes/Data/slave/highsierra-leaks/build/layout-test-results/DumpRenderTree-4648-leaks.txt --memgraph-file=/Volumes/Data/slave/highsierra-leaks/build/layout-test-results/DumpRenderTree-4648.memgraph 4648" took 0.25s 02:25:40.178 1965 Output of ['Tools/Scripts/run-leaks', '--exclude-callstack=WTF::BitVector::OutOfLineBits::create', '--exclude-callstack=WTF::BitVector::resizeOutOfLine', '--exclude-callstack=WebCore::createPrivateStorageSession', '--exclude-callstack=CIDeviceManagerStartMonitoring', '--exclude-callstack=NSSpellChecker init', '--exclude-callstack=NSColor controlHighlightColor', '--output-file=/Volumes/Data/slave/highsierra-leaks/build/layout-test-results/DumpRenderTree-4648-leaks.txt', '--memgraph-file=/Volumes/Data/slave/highsierra-leaks/build/layout-test-results/DumpRenderTree-4648.memgraph', 4648]: leaks[4889]: leaks cannot examine process 4648 (DumpRenderTree) for unknown reasons, even though it appears to exist; try running with `sudo`. leaks[4890]: [fatal] unable to read input graph: The file “DumpRenderTree-4648.memgraph” couldn’t be opened because there is no such file. leaks[4891]: [fatal] unable to read input graph: The file “DumpRenderTree-4648.memgraph” couldn’t be opened because there is no such file. Use of uninitialized value $leakCount in numeric ne (!=) at Tools/Scripts/run-leaks line 214.

Note You need to log in before you can comment on or make changes to this bug.