Summary: | [WebAuthN] Polish AuthenticatorManager and rename it to AuthenticatorCoordinator | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | alex.gaynor, bfulgham, cdumez, commit-queue, esprehn+autocc, ews-watchlist, jiewen_tan, kondapallykalyan, mkwst, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 181943 | ||||||||||||||
Attachments: |
|
Description
Jiewen Tan
2018-09-04 15:39:40 PDT
Created attachment 349266 [details]
Patch
Created attachment 349274 [details]
Patch
Created attachment 349318 [details]
Patch
Comment on attachment 349318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349318&action=review r=me with suggestions. > Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h:98 > + encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(user.id.data()), user.id.length(), 1); Why do we need the reinterpret_cast here? Also, it seems like this could construct a temporary IPC::DataReference and encode that. > Source/WebCore/page/Page.h:910 > + std::unique_ptr<AuthenticatorCoordinator> m_authenticatorCoordinator; Could this be a UniqueRef instead of a unique_ptr? It seems it cannot be null. Comment on attachment 349318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349318&action=review Thanks Chris for r+ this patch. >> Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h:98 >> + encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(user.id.data()), user.id.length(), 1); > > Why do we need the reinterpret_cast here? > > Also, it seems like this could construct a temporary IPC::DataReference and encode that. It doesn't need to. IPC::DataReference is in WebKit so I could't use it in WebCore. >> Source/WebCore/page/Page.h:910 >> + std::unique_ptr<AuthenticatorCoordinator> m_authenticatorCoordinator; > > Could this be a UniqueRef instead of a unique_ptr? It seems it cannot be null. Sure, I was not aware of UniqueRef. Created attachment 349336 [details]
Patch for landing
Created attachment 349347 [details]
Patch for landing
Comment on attachment 349347 [details]
Patch for landing
Added #include <JavaScriptCore/HeapInlines.h> to VRStageParameters.cpp to resolve the Win EWS bots linker error.
Comment on attachment 349347 [details] Patch for landing Clearing flags on attachment: 349347 Committed r235888: <https://trac.webkit.org/changeset/235888> Build fix: Committed r235900: <https://trac.webkit.org/changeset/235900> |