Bug 189270

Summary: Make LibWebRTCRtpSenderBackend own its libwebrtc RTP sender backend
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2018-09-04 13:01:37 PDT
Make LibWebRTCRtpSenderBackend own its libwebrtc RTP sender backend
Attachments
Patch (21.29 KB, patch)
2018-09-04 15:31 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.32 KB, patch)
2018-09-04 16:31 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-09-04 15:31:10 PDT
Created attachment 348857 [details] Patch
Eric Carlson
Comment 2 2018-09-04 16:21:00 PDT
Comment on attachment 348857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348857&action=review > Source/WebCore/ChangeLog:8 > + Previously, the libwebrtc sender were owned in LibWebRTCMediaEndpoint. Nit: sender -> senders > Source/WebCore/ChangeLog:9 > + This patch makes them owned by LibWebRTCRtpSenderBackend. Nit: makes them owned by -> makes them be owned by > Source/WebCore/ChangeLog:11 > + This will help simplifying the implementation of RTCRtpSender::replaceTrack. Nit: simplifying -> simplify > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:258 > + if (m_peerConnectionBackend.shouldOfferAllowToReceive("audio")) Nit: "audio" -> "audio"_s > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:260 > + if (m_peerConnectionBackend.shouldOfferAllowToReceive("video")) Nit: "video" -> "video"_s
youenn fablet
Comment 3 2018-09-04 16:31:51 PDT
Created attachment 348870 [details] Patch for landing
WebKit Commit Bot
Comment 4 2018-09-04 17:04:07 PDT
Comment on attachment 348870 [details] Patch for landing Clearing flags on attachment: 348870 Committed r235649: <https://trac.webkit.org/changeset/235649>
WebKit Commit Bot
Comment 5 2018-09-04 17:04:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-09-04 17:06:16 PDT
<rdar://problem/44118910>
Note You need to log in before you can comment on or make changes to this bug.