Bug 189268

Summary: Make the jsc shell print, printErr, and debug functions more robust.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. keith_miller: review+, mark.lam: commit-queue-

Mark Lam
Reported 2018-09-04 12:07:27 PDT
We'll now check for UTF8 conversion errors. <rdar://problem/41192690>
Attachments
proposed patch. (3.34 KB, patch)
2018-09-04 12:11 PDT, Mark Lam 		keith_miller: review+
mark.lam: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-09-04 12:11:13 PDT
Created attachment 348836 [details] proposed patch.
Mark Lam
Comment 2 2018-09-04 12:13:16 PDT
Comment on attachment 348836 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=348836&action=review > Source/JavaScriptCore/jsc.cpp:1030 > + scope.throwException(exec, createError(exec, "Source exhausted encountered during UTF8 conversion")); I should remove the "encountered" here.
Keith Miller
Comment 3 2018-09-04 12:20:07 PDT
Comment on attachment 348836 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=348836&action=review r=me. >> Source/JavaScriptCore/jsc.cpp:1030 >> + scope.throwException(exec, createError(exec, "Source exhausted encountered during UTF8 conversion")); > > I should remove the "encountered" here. What does SourceExhausted error actually mean anyway?
Mark Lam
Comment 4 2018-09-04 12:46:55 PDT
(In reply to Keith Miller from comment #3) > What does SourceExhausted error actually mean anyway? From convertUTF8ToUTF16() in UTF8.cpp, I think it means that a multi-byte encoding got cut off (i.e. missing bytes).
Mark Lam
Comment 5 2018-09-04 12:49:10 PDT
Thanks for the review. Landed in r235627: <http://trac.webkit.org/r235627>.
Note You need to log in before you can comment on or make changes to this bug.