Bug 189251

Summary: Add helper function to create a potential CORS request
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ddkilzer, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2018-09-03 16:42:57 PDT
CachedResourceRequest::setAsPotentiallyCrossOrigin() mixes the concepts of CORS settings states (No CORS, Anonymous and Use Credentials) and module script credentials mode ("omit", "same-origin", and "include") into an algorithm that has a passing resemblance of the algorithm Create a potential-CORS request from the HTML standard: <https://html.spec.whatwg.org/multipage/urls-and-fetching.html#create-a-potential-cors-request> (31 August 2018). Although the standard describes a mapping between CORS settings states and module script credentials modes it is error prone and confusing for setAsPotentiallyCrossOrigin() to support both concepts, called a "cross origin mode", as input to it. We should separate these concepts and more closely implement the algorithm Create a potential-CORS request from the HTML standard.
Attachments
Patch (17.69 KB, patch)
2018-09-03 16:56 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-09-03 16:56:40 PDT
Created attachment 348795 [details] Patch
Daniel Bates
Comment 2 2018-09-04 10:11:10 PDT
Comment on attachment 348795 [details] Patch Clearing flags on attachment: 348795 Committed r235617: <https://trac.webkit.org/changeset/235617>
Daniel Bates
Comment 3 2018-09-04 10:11:11 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-09-04 10:13:02 PDT
<rdar://problem/44101478>
Note You need to log in before you can comment on or make changes to this bug.