Bug 189249 – [Payment Request] PaymentResponse should have an onpayerdetailchange event handler

• Component: New Bugs
• Status: RESOLVED FIXED

[Andy Estes]

[Payment Request] PaymentResponse should have an onpayerdetailchange event handler

[Andy Estes]

Created attachment 348790 [details]
Patch

[Alex Christensen]

Comment on attachment 348790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348790&action=review

> Source/WebCore/Modules/paymentrequest/PaymentResponse.cpp:57
> +    return static_cast<ActiveDOMObject&>(m_request.get()).scriptExecutionContext();

You shouldn't need the static cast here.  Just m_request->scriptExecutionContext() ought to work.

[Andy Estes]

Comment on attachment 348790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348790&action=review

>> Source/WebCore/Modules/paymentrequest/PaymentResponse.cpp:57
>> +    return static_cast<ActiveDOMObject&>(m_request.get()).scriptExecutionContext();
> 
> You shouldn't need the static cast here.  Just m_request->scriptExecutionContext() ought to work.

Unfortunately not, because PaymentRequest overrides scriptExecutionContext() as a private member function. I guess I could change that to be public, or make PaymentResponse be a ContextDestructionObserver. I'll think about how I want to improve this.

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 348790 [details]
Patch

Rejecting attachment 348790 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 348790, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=348790&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=189249&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 348790 from bug 189249.
Fetching: https://bugs.webkit.org/attachment.cgi?id=348790
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 8 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Modules/paymentrequest/PaymentResponse.cpp
Hunk #2 succeeded at 59 with fuzz 1 (offset 7 lines).
patching file Source/WebCore/Modules/paymentrequest/PaymentResponse.h
Hunk #3 succeeded at 38 with fuzz 2 (offset 1 line).
Hunk #4 succeeded at 74 with fuzz 2 (offset 2 lines).
patching file Source/WebCore/Modules/paymentrequest/PaymentResponse.idl
Hunk #3 FAILED at 41.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/Modules/paymentrequest/PaymentResponse.idl.rej
patching file Source/WebCore/dom/EventNames.h
patching file Source/WebCore/dom/EventTargetFactory.in
patching file LayoutTests/imported/w3c/ChangeLog
patching file LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-response/onpayerdetailchange-attribute.https-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/9091174

[Andy Estes]

Created attachment 348833 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 348833 [details]
Patch

Clearing flags on attachment: 348833

Committed r235625: <https://trac.webkit.org/changeset/235625>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44107683>