Bug 189235

Summary:

[Payment Request] Implement the MerchantValidationEvent constructor

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, andersca, cdumez, commit-queue, dbates, eric.carlson, ews-watchlist, rniwa, sam, thorton, webkit-bug-importer, wenson_hsieh, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none

Andy Estes

Reported 2018-09-02 20:12:24 PDT

Update payment-request web platform tests to 0313d9f

Attachments
Patch (73.68 KB, patch) 2018-09-02 20:15 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.83 MB, application/zip) 2018-09-02 21:26 PDT, EWS Watchlist	no flags	Details
Patch (99.36 KB, patch) 2018-09-02 21:50 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.80 MB, application/zip) 2018-09-02 23:11 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.28 MB, application/zip) 2018-09-02 23:52 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (8.68 MB, application/zip) 2018-09-03 01:51 PDT, EWS Watchlist	no flags	Details
Patch (99.41 KB, patch) 2018-09-03 08:54 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2018-09-02 20:15:31 PDT Comment hidden (obsolete)

Created attachment 348754 [details] Patch

EWS Watchlist

Comment 2 2018-09-02 21:26:33 PDT Comment hidden (obsolete)

Comment on attachment 348754 [details] Patch Attachment 348754 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9075179 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 3 2018-09-02 21:26:35 PDT Comment hidden (obsolete)

Created attachment 348755 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Andy Estes

Comment 4 2018-09-02 21:50:16 PDT Comment hidden (obsolete)

Created attachment 348757 [details] Patch

Daniel Bates

Comment 5 2018-09-02 22:52:06 PDT

Comment on attachment 348757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348757&action=review r=me > Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp:51 > MerchantValidationEvent::MerchantValidationEvent(const AtomicString& type, const URL& validationURL, PaymentRequest& paymentRequest) For your consideration, I suggest we change the data type of paymentRequest to a Ref<PaymentRequest>&& to convey that the caller is transferring ownership.

Daniel Bates

Comment 6 2018-09-02 23:07:52 PDT

(In reply to Daniel Bates from comment #5) > > Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp:51 > > MerchantValidationEvent::MerchantValidationEvent(const AtomicString& type, const URL& validationURL, PaymentRequest& paymentRequest) > > For your consideration, I suggest we change the data type of paymentRequest > to a Ref<PaymentRequest>&& to convey that the caller is transferring > ownership. Disregard this remark.

EWS Watchlist

Comment 7 2018-09-02 23:11:15 PDT Comment hidden (obsolete)

Comment on attachment 348757 [details] Patch Attachment 348757 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9075793 New failing tests: imported/w3c/web-platform-tests/payment-request/payment-request-canmakepayment-method.https.html imported/w3c/web-platform-tests/payment-request/payment-request-abort-method.https.html

EWS Watchlist

Comment 8 2018-09-02 23:11:16 PDT Comment hidden (obsolete)

Created attachment 348759 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-09-02 23:52:45 PDT Comment hidden (obsolete)

Comment on attachment 348757 [details] Patch Attachment 348757 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9075848 New failing tests: imported/w3c/web-platform-tests/payment-request/payment-request-canmakepayment-method.https.html imported/w3c/web-platform-tests/payment-request/payment-request-abort-method.https.html

EWS Watchlist

Comment 10 2018-09-02 23:52:47 PDT Comment hidden (obsolete)

Created attachment 348760 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 11 2018-09-03 01:51:40 PDT Comment hidden (obsolete)

Comment on attachment 348757 [details] Patch Attachment 348757 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9076439 New failing tests: imported/w3c/web-platform-tests/payment-request/payment-request-canmakepayment-method.https.html imported/w3c/web-platform-tests/payment-request/payment-request-abort-method.https.html

EWS Watchlist

Comment 12 2018-09-03 01:51:42 PDT Comment hidden (obsolete)

Created attachment 348763 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Andy Estes

Comment 13 2018-09-03 08:54:31 PDT

Created attachment 348773 [details] Patch

WebKit Commit Bot

Comment 14 2018-09-03 10:16:08 PDT

Comment on attachment 348773 [details] Patch Clearing flags on attachment: 348773 Committed r235600: <https://trac.webkit.org/changeset/235600>

WebKit Commit Bot

Comment 15 2018-09-03 10:16:10 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 16 2018-09-03 10:17:20 PDT

<rdar://problem/44074727>

Note You need to log in before you can comment on or make changes to this bug.