Bug 189208

Summary: Web Inspector: imported recordings are unable to be viewed after navigation
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied none

Devin Rousso
Reported 2018-08-31 13:32:04 PDT
STEPS TO REPRODUCE: 1. Go to a page with a 2D canvas 2. Take a recording 3. Refresh the page => "Canvas #" still shows in the navigation sidebar 4. Click back to the "overview" (the path component should've changed to "Imported Recordings" => No way to look at the imported recording (you'd have to select a canvas, and then click the canvas path component dropdown to select the "Imported Recordings" folder)
Attachments
Patch (10.91 KB, patch)
2018-08-31 13:36 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (30.64 KB, image/png)
2018-09-02 09:59 PDT, Devin Rousso 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-08-31 13:36:58 PDT
Created attachment 348668 [details] Patch
Matt Baker
Comment 2 2018-08-31 14:12:49 PDT
Nice! Screenshots showing new UI would be great.
Devin Rousso
Comment 3 2018-09-02 09:59:34 PDT
Created attachment 348738 [details] [Image] After Patch is applied (In reply to Matt Baker from comment #2) > Nice! Screenshots showing new UI would be great. Sorry, my laptop ran out of battery almost immediately after I uploaded the patch 😅
Joseph Pecoraro
Comment 4 2018-09-11 18:35:14 PDT
Comment on attachment 348668 [details] Patch rs=me
WebKit Commit Bot
Comment 5 2018-09-12 09:11:07 PDT
Comment on attachment 348668 [details] Patch Clearing flags on attachment: 348668 Committed r235937: <https://trac.webkit.org/changeset/235937>
WebKit Commit Bot
Comment 6 2018-09-12 09:11:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-09-12 09:12:22 PDT
<rdar://problem/44385390>
Note You need to log in before you can comment on or make changes to this bug.