Bug 189182

Summary: Move LibWebRTCMediaEndpoint data channel code to LibWebRTCDataChannelHandler
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2018-08-30 21:26:38 PDT
Refactoring to ease future developments.
Attachments
Patch (9.67 KB, patch)
2018-08-30 21:28 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (9.81 KB, patch)
2018-08-30 21:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-08-30 21:28:37 PDT
Created attachment 348593 [details] Patch
youenn fablet
Comment 2 2018-08-30 21:45:20 PDT
Created attachment 348601 [details] Patch
Alejandro G. Castro
Comment 3 2018-08-31 06:26:05 PDT
Comment on attachment 348601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348601&action=review LGTM > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:750 > + auto& connection = protectedThis->m_peerConnectionBackend.connection(); > + connection.fireEvent(LibWebRTCDataChannelHandler::channelEvent(*connection.scriptExecutionContext(), WTFMove(dataChannel))); You can avoid the connection variable.
youenn fablet
Comment 4 2018-08-31 08:25:04 PDT
> > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:750 > > + auto& connection = protectedThis->m_peerConnectionBackend.connection(); > > + connection.fireEvent(LibWebRTCDataChannelHandler::channelEvent(*connection.scriptExecutionContext(), WTFMove(dataChannel))); > > You can avoid the connection variable. Right, I think it reads better as two lines though.
WebKit Commit Bot
Comment 5 2018-08-31 08:52:04 PDT
Comment on attachment 348601 [details] Patch Clearing flags on attachment: 348601 Committed r235552: <https://trac.webkit.org/changeset/235552>
WebKit Commit Bot
Comment 6 2018-08-31 08:52:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-08-31 08:53:33 PDT
<rdar://problem/43941822>
Note You need to log in before you can comment on or make changes to this bug.