Bug 189159

Summary: [MediaStream] Remove AVMediaCaptureSource
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Eric Carlson
Reported 2018-08-30 10:45:43 PDT
We only use AVCapture for video now, so there is no need for base class.
Attachments
Patch (61.53 KB, patch)
2018-08-30 10:52 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (55.44 KB, patch)
2018-08-30 11:30 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (39.31 KB, patch)
2018-08-30 12:38 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (39.72 KB, patch)
2018-08-30 14:30 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (42.26 KB, patch)
2018-08-31 05:04 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2018-08-30 10:52:52 PDT
Created attachment 348508 [details] Patch
Eric Carlson
Comment 2 2018-08-30 11:30:57 PDT
Created attachment 348519 [details] Patch for landing
Eric Carlson
Comment 3 2018-08-30 12:38:22 PDT
Created attachment 348529 [details] Patch for landing
Eric Carlson
Comment 4 2018-08-30 14:30:12 PDT
Created attachment 348551 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-08-30 16:40:44 PDT
Comment on attachment 348551 [details] Patch for landing Rejecting attachment 348551 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 348551, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file. Full output: https://webkit-queues.webkit.org/results/9041724
Eric Carlson
Comment 6 2018-08-31 05:04:46 PDT
Created attachment 348635 [details] Patch for landing
Radar WebKit Bug Importer
Comment 7 2018-08-31 05:05:01 PDT
<rdar://problem/43935721>
WebKit Commit Bot
Comment 8 2018-08-31 05:43:39 PDT
Comment on attachment 348635 [details] Patch for landing Clearing flags on attachment: 348635 Committed r235549: <https://trac.webkit.org/changeset/235549>
WebKit Commit Bot
Comment 9 2018-08-31 05:43:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.