Bug 189137

Summary: grid track size should reject unitless length
Product: WebKit Reporter: Eric Willigers <ericwilligers>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, macpherson, menard, rbuis, rego, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari 11   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Eric Willigers
Reported 2018-08-29 18:22:35 PDT
In quirks mode, Safari currently accepts unitless lengths for the following properties: - grid-auto-columns - grid-auto-rows - grid-template-columns - grid-template-rows This is contrary to spec. https://quirks.spec.whatwg.org/#the-unitless-length-quirk https://drafts.csswg.org/css-grid/#track-sizing
Attachments
Patch (4.88 KB, patch)
2021-05-21 00:10 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2021-05-21 01:45 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Willigers
Comment 1 2018-08-29 18:26:39 PDT
background-size should also reject unitless length.
Eric Willigers
Comment 2 2018-10-25 23:34:51 PDT
See also https://bugs.webkit.org/show_bug.cgi?id=104805
Rob Buis
Comment 3 2021-05-21 00:10:03 PDT
Created attachment 429269 [details] Patch
Rob Buis
Comment 4 2021-05-21 01:45:07 PDT
Created attachment 429272 [details] Patch
Sergio Villar Senin
Comment 5 2021-05-21 08:51:52 PDT
Comment on attachment 429272 [details] Patch Nice!
EWS
Comment 6 2021-05-21 10:16:28 PDT
Committed r277868 (238008@main): <https://commits.webkit.org/238008@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429272 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-21 10:17:21 PDT
<rdar://problem/78316259>
Note You need to log in before you can comment on or make changes to this bug.