Summary: | ASSERTION FAILED: m_networkLoadInformationByID.contains(identifier) in WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationMetrics | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||||
Component: | Web Inspector | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, inspector-bugzilla-changes, jlewis3, joepeck, realdawei, tsavell, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Created attachment 359194 [details]
Patch
Comment on attachment 359194 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359194&action=review > Source/WebKit/NetworkProcess/NetworkResourceLoader.h:116 > + void shouldNotCaptureExtraNetworkLoadMetricsEnabled() { m_shouldCaptureExtraNetworkLoadMetrics = false; } This is a poorly named function. void setShouldNotCaptureExtraNetworkLoadMetrics(bool) (In reply to Alex Christensen from comment #3) > Comment on attachment 359194 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=359194&action=review > > > Source/WebKit/NetworkProcess/NetworkResourceLoader.h:116 > > + void shouldNotCaptureExtraNetworkLoadMetricsEnabled() { m_shouldCaptureExtraNetworkLoadMetrics = false; } > > This is a poorly named function. void > setShouldNotCaptureExtraNetworkLoadMetrics(bool) Let's rename it to disableExtraNetworkLoadMetricsCapture(). I do not really like the idea of setShouldNotCaptureExtraNetworkLoadMetrics(true). Created attachment 359315 [details]
Patch for landing
Comment on attachment 359315 [details] Patch for landing Clearing flags on attachment: 359315 Committed r240089: <https://trac.webkit.org/changeset/240089> All reviewed patches have been landed. Closing bug. |
Created attachment 348428 [details] Crash log The following assertion failure was seen with layout test inspector/worker/console-basic.html: ASSERTION FAILED: m_networkLoadInformationByID.contains(identifier) /Volumes/Data/slave/sierra-debug/build/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h(108) : void WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationMetrics(ResourceLoadIdentifier, const WebCore::NetworkLoadMetrics &) 1 0x121b85699 WTFCrash 2 0x10c5749fb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10c85d9c0 WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationMetrics(unsigned long long, WebCore::NetworkLoadMetrics const&) 4 0x10c85d493 WebKit::NetworkResourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) 5 0x10c81868c WebKit::NetworkLoad::didCompleteWithError(WebCore::ResourceError const&, WebCore::NetworkLoadMetrics const&) 6 0x10c8c4fc7 WebKit::NetworkDataTaskCocoa::didCompleteWithError(WebCore::ResourceError const&, WebCore::NetworkLoadMetrics const&) 7 0x10c8c8dd3 -[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:] 8 0x7fffbb8655c1 __51-[NSURLSession delegate_task:didCompleteWithError:]_block_invoke.162 9 0x7fffbdf81f19 __NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK__ 10 0x7fffbdf81bfc -[NSBlockOperation main] 11 0x7fffbdf80324 -[__NSOperationInternal _start:] 12 0x7fffbdf7c1db __NSOQSchedule_f 13 0x7fffd20c38fc _dispatch_client_callout 14 0x7fffd20d0aac _dispatch_main_queue_callback_4CF 15 0x7fffbc56ed69 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ 16 0x7fffbc53004d __CFRunLoopRun 17 0x7fffbc52f544 CFRunLoopRunSpecific 18 0x7fffbdf60252 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 19 0x7fffbdf6012a -[NSRunLoop(NSRunLoop) run] 20 0x7fffd235289b _xpc_objc_main 21 0x7fffd23512e4 xpc_main 22 0x10a512091 WebKit::XPCServiceMain() 23 0x10a51237b main 24 0x7fffd20f9235 start 25 0x1