Bug 189073

Summary: IDBDatabase should not return true to hasPendingActivity after being stopped
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, commit-queue, darin, ews-watchlist, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2018-08-28 20:32:36 PDT
IDBDatabase should not return true to hasPendingActivity after being stopped
Attachments
Patch (1.97 KB, patch)
2018-08-28 20:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-08-28 20:36:53 PDT
Created attachment 348384 [details] Patch
Darin Adler
Comment 2 2018-08-28 20:39:23 PDT
Comment on attachment 348384 [details] Patch No way to make a regression test?
youenn fablet
Comment 3 2018-08-28 21:26:01 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 348384 [details] > Patch > > No way to make a regression test? AFAIUI, IDBDatabase::hasPendingActivity will stop returning true once transactions are finalized which will happen ultimately, but not always before GC calls IDBDatabase::hasPendingActivity for the first time. This patch makes IDBDatabase GC-collectable sooner but I do not think it makes some leaked IDBDatabase no longer leaking, so there is no easy way to add a test for that change. This will be captured with bug 189018, which asserts that a stopped ActiveDOMObject hasPendingActivity to return false. Without this patch, some IDB tests would crash.
WebKit Commit Bot
Comment 4 2018-08-28 21:52:52 PDT
Comment on attachment 348384 [details] Patch Clearing flags on attachment: 348384 Committed r235456: <https://trac.webkit.org/changeset/235456>
WebKit Commit Bot
Comment 5 2018-08-28 21:52:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-28 21:53:24 PDT
<rdar://problem/43828788>
Note You need to log in before you can comment on or make changes to this bug.