Bug 18906

Summary: [GTK] Fix varargs terminator in g_build_filename()
Product: WebKit Reporter: Gwenole Beauchesne <gb.devel>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alp, voyageursp
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Fix varargs terminator alp: review+

Description Gwenole Beauchesne 2008-05-06 04:18:47 PDT 
g_build_filename() is NULL terminated, or (void *)0 with your coding style if you prefer.

It currently works by luck on Linux/x86_64 because g_build_filename() args are <= 6, so they are all passed through registers.
Comment 1 Gwenole Beauchesne 2008-05-06 04:19:29 PDT 
Created attachment 20982 [details]
Fix varargs terminator
Comment 2 Alp Toker 2008-05-06 13:20:31 PDT 
Comment on attachment 20982 [details]
Fix varargs terminator

r=me

The patch utility didn't like this, I had to hand apply it. Please check the formatting of the ChangeLog entry too next time.

Thanks
Comment 3 Alp Toker 2008-05-06 13:21:07 PDT 
Landed in r32913.