Bug 189056

Summary: [Curl][WebKit] Bugfix on redirect.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, commit-queue, don.olmstead, fujii.hironori, webkit-bug-importer, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
achristensen: review+, achristensen: commit-queue-
fix none

Basuke Suzuki
Reported 2018-08-28 13:38:50 PDT
Forget to call request update method.
Attachments
PATCH (1.46 KB, patch)
2018-08-28 13:43 PDT, Basuke Suzuki 		achristensen: review+
achristensen: commit-queue-
DetailsFormatted DiffDiff
fix (1.44 KB, patch)
2018-08-30 10:34 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-08-28 13:43:07 PDT
Created attachment 348335 [details] PATCH
Don Olmstead
Comment 2 2018-08-29 13:15:08 PDT
Comment on attachment 348335 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=348335&action=review LGTM from my informal review. > Source/WebKit/NetworkProcess/NetworkLoad.cpp:154 > +#elif USE(SOUP) || USE(CURL) Minor nit. Should this just be an #else?
Alex Christensen
Comment 3 2018-08-29 18:55:51 PDT
Comment on attachment 348335 [details] PATCH Yep
Basuke Suzuki
Comment 4 2018-08-30 10:34:59 PDT
Created attachment 348504 [details] fix
Basuke Suzuki
Comment 5 2018-08-30 10:36:34 PDT
Thanks. I forgot we can forget about AppleWin in this component.
WebKit Commit Bot
Comment 6 2018-08-30 11:13:09 PDT
Comment on attachment 348504 [details] fix Clearing flags on attachment: 348504 Committed r235510: <https://trac.webkit.org/changeset/235510>
WebKit Commit Bot
Comment 7 2018-08-30 11:13:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.