Bug 189054

Summary: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Part 1
none
Part 1 (rebased)
none
Patch
none
Try to fix the WPE build. none

Wenson Hsieh
Reported 2018-08-28 13:32:19 PDT
There shouldn't be two different implementations in the same place for reading a value for a given type from the platform pasteboard on iOS. Furthermore, there shouldn't be three (!!!) different implementations in the same file for reading a URL from the pasteboard on iOS. It's also unclear why readURL even takes a type identifier as an argument, if our code only ever hands it "public.url"...
Attachments
Part 1 (18.29 KB, patch)
2018-08-28 14:06 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Part 1 (rebased) (16.03 KB, patch)
2018-08-28 14:11 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (10.65 KB, patch)
2018-08-30 12:04 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Try to fix the WPE build. (11.58 KB, patch)
2018-08-30 12:14 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-08-28 13:37:56 PDT
This code has been like this for many years now, and changing this probably carries some risk. But at the very least, unifying these codepaths to all funnel into the same implementations on iOS would make it much, much easier to hack on this code moving forward. I would like to try and resolve this before introducing any more complexity to this area, en route to supporting multiple entries in DataTransfer.getData("text/uri-list") on iOS when dropping or pasting multiple URLs.
Wenson Hsieh
Comment 2 2018-08-28 14:06:25 PDT
Created attachment 348340 [details] Part 1
Wenson Hsieh
Comment 3 2018-08-28 14:11:37 PDT
Created attachment 348341 [details] Part 1 (rebased)
WebKit Commit Bot
Comment 4 2018-08-28 16:28:27 PDT
Comment on attachment 348341 [details] Part 1 (rebased) Clearing flags on attachment: 348341 Committed r235448: <https://trac.webkit.org/changeset/235448>
WebKit Commit Bot
Comment 5 2018-08-28 16:28:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-28 16:29:17 PDT
<rdar://problem/43819779>
Wenson Hsieh
Comment 7 2018-08-28 20:15:35 PDT
Reopening, since this was only the first part — there's more to come…
Wenson Hsieh
Comment 8 2018-08-30 12:04:33 PDT
Created attachment 348524 [details] Patch
Wenson Hsieh
Comment 9 2018-08-30 12:14:12 PDT
Created attachment 348526 [details] Try to fix the WPE build.
WebKit Commit Bot
Comment 10 2018-08-31 16:18:37 PDT
Comment on attachment 348526 [details] Try to fix the WPE build. Clearing flags on attachment: 348526 Committed r235574: <https://trac.webkit.org/changeset/235574>
WebKit Commit Bot
Comment 11 2018-08-31 16:18:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.